Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mutation test script for changed code #757

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Introduce mutation test script for changed code #757

merged 2 commits into from
Aug 28, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Aug 19, 2023 •
edited
Loading

Suggested commit message:

Introduce mutation test script for changed code (#757)

While there, optimize the existing `run-mutation-tests.sh` script.

@Stephan202 Stephan202 added this to the 0.13.0 milestone Aug 19, 2023
@Stephan202 Stephan202 requested a review from rickie August 19, 2023 17:17
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Aug 22, 2023
@rickie rickie modified the milestones: 0.13.0, 0.14.0 Aug 25, 2023
@rickie rickie force-pushed the sschroevers/mutation-test-script-improvements branch from aff691e to cebae8e Compare August 25, 2023 19:16
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider.

run-branch-mutation-tests.sh
set -e -u -o pipefail

if [ "${#}" -gt 1 ]; then
echo "Usage: ${0} [DiffSpec]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to have something like opt: in here right? In case of optional arguments we internally usually do:
<opt: diff-spec>.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we don't do it for the other, but now we worked a lot more with bash so we made some improvements here and there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, square brackets represent optionality; this alternative is less idiomatic IMHO.

@Stephan202 @rickie
Introduce mutation test script for changed code
afadc27 
While there, optimize the existing `run-mutation-tests.sh` script.
@rickie rickie force-pushed the sschroevers/mutation-test-script-improvements branch from cebae8e to afadc27 Compare August 26, 2023 08:19
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Wait, we should also update the main README; not sure how I missed that. Will add a commit.

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rickie
rickie approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal LGTM!

@rickie rickie merged commit 6131599 into master Aug 28, 2023
@rickie rickie deleted the sschroevers/mutation-test-script-improvements branch August 28, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@nov1n nov1n nov1n approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @nov1n @rickie