Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade org.hamcrest:hamcrest-library 1.3 -> 2.2 #70

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Update Change
org.hamcrest:hamcrest-library (source) major 1.3 -> 2.2

Release Notes

hamcrest/JavaHamcrest

v2.2

Compare Source

Improvements
Bugfixes

v2.1

Overview for 2.1

After a long hiatus without releases, this version simplifies the packaging of
Hamcrest into a single jar: hamcrest-<version>.jar. Other big changes include
Java 9 module compatibility, migrating the code repository from Google Code to
GitHub, along with numerous other new features, improvements and bug fixes.

Breaking Changes for 2.1
  • The way that the project is packaged has changed. This may cause problems with
    correctly upgrading transitive dependencies. Refer to the
    Hamcrest Distributables
    documentation for more information, and in particular,
    Upgrading from Hamcrest 1.x
  • org.hamcrest.Factory has been removed. This was only used in old implementations
    of the hamcrest build toolchain, and can safely be deleted from client code without
    any effect.
Changes for 2.1
  • Documentation updates
  • Several JavaDoc improvements and corrections
  • Fix JavaDoc examples
  • Upgraded to Java 7
  • Build with Gradle
  • Publish a single jar hamcrest-2.1.jar
  • Publish pom-only artifacts for hamcrest-core and hamcrest-library.
  • Add implementation for CharSequence length matcher
  • Fix for TypeSafeDiagnosingMatcher can't detect generic types for subclass
  • Make Hamcrest an OSGI bundle
  • Add StringRegularExpression matcher
  • Fix StringContainsInOrder to detect if a repeated pattern is missing
  • Add ArrayAsIterableMatcher
  • Fix description for IsEqualIgnoringCase
  • Removed deprecated methods from previous release
  • Improve mismatch description of hasItem/hasItems
  • General improvements to mismatch descriptions
  • Deprecated several matcher factory methods of the for "isXyz"
  • Fix GH issue #​75 - address doclint errors reported in JDK 1.8
  • Fix GH issue #​69 - Iterable contains in order is null-safe
  • Fix GH issue #​59 - added equalToObject() (i.e. unchecked) method
  • Fix GH issue #​25 - arrayContaining(null, null) cause NullPointerException
  • Fix GH issue #​36 - string matching on regular expressions
  • Fix GH issue #​8 - isCloseTo() shows wrong delta in mismatch description
  • Fix GH issue #​59 - add untyped version of equalTo, named equalToObject
  • Fix GC issue #​131 - Implement IsEmptyMap, IsMapWithSize
  • Fix GC issue #​187 - IsArray.describeMismatchSafely() should use Matcher.describeMismatch
  • Fix GC issue #​155 - Add Matcher implementation for files
  • Fix GC issue #​69 - fix NPE in IsIterableContainingInOrder

  • If you want to rebase/retry this PR, click this checkbox.

@Picnic-Bot
Copy link
Contributor Author

Suggested commit message:

Upgrade hamcrest-library 1.3 -> 2.2

See:
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc1
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc2
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc3
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc4
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.2
- https://github.com/hamcrest/JavaHamcrest/compare/v2.1...v2.2

(JUnit 4 still declares a dependency on `hamcrest-{core,library}`.)
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to fix the build.

Updated suggested commit message:

Upgrade Hamcrest 1.3 -> 2.2 (#70)

See:
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc1
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc2
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc3
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1-rc4
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.2-rc1
- https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.2
- https://github.com/hamcrest/JavaHamcrest/compare/hamcrest-java-1.3...v2.2

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

To be frank, I thought we also didn't list release candidates in the commit message.

@Stephan202
Copy link
Member

"It depends". If there's useful information in there we should include it. We often drop them because the suggested commit message plugin has a bug that causes RCs associated with the preceding version to be included. (There's already code to fix that; just need to open a PR.)

@Stephan202 Stephan202 merged commit b2316c7 into master Apr 24, 2022
@Stephan202 Stephan202 deleted the renovate/org.hamcrest-hamcrest-library-2.x branch April 24, 2022 12:24
@Stephan202 Stephan202 added this to the 0.1.0 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants