Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate to pin GitHub Action digests #675

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

rickie
Copy link
Member

@rickie rickie commented Jun 7, 2023

Verified this against a private Renovate testing repository. Here are some examples of the changes:

-        uses: actions/[email protected]
+        uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
...
-        uses: actions/[email protected]
+        uses: actions/setup-java@5ffc13f4174014e2d4d4572b3d74c3fa61aeb2c2 # v3.11.0

So after we merge, we can retrigger Renovate and review the upgrade PRs.
For extra information, see the documentation: https://docs.renovatebot.com/modules/manager/github-actions/

The next hurdle here is figuring out how our suggested commit message bot works with this 🤔.

@rickie rickie requested review from Stephan202 and Badbond June 7, 2023 14:24
@rickie rickie added this to the 0.12.0 milestone Jun 7, 2023
@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

@rickie
Copy link
Member Author

rickie commented Jun 7, 2023

Suggested commit message:

Configure Renovate to pin GitHub Action digests (#675)

Copy link
Member

@Badbond Badbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran it on a private repo and found nothing out of the ordinary. As to answer:

The next hurdle here is figuring out how our suggested commit message bot works with this thinking.

The PR title is identical, therefore suggest commit message will behave exactly the same as before.

One thing we can consider is moving this into the global configuration; couldn't hurt. In any case, will ✔️.

@rickie
Copy link
Member Author

rickie commented Jun 8, 2023

One thing we can consider is moving this into the global configuration; couldn't hurt. In any case, will heavy_check_mark.

Yeah I can make a PR for that. I think it is nice to have. There are some other repositories that use GHA it I believe.

@rickie rickie merged commit cee3c58 into master Jun 8, 2023
@rickie rickie deleted the rossendrijver/pin_github_action_digests branch June 8, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants