Upgrade Error Prone 2.18.0 -> 2.19.1 #621

Picnic-Bot · 2023-05-10T01:03:00Z

This PR contains the following updates:

Package	Type	Update	Change
com.google.errorprone:error_prone_annotations (source)	compile	minor	`2.18.0` -> `2.19.0`
com.google.errorprone:error_prone_core (source)		minor	`2.18.0` -> `2.19.0`
com.google.errorprone:error_prone_test_helpers (source)	compile	minor	`2.18.0` -> `2.19.0`
com.google.errorprone:error_prone_core (source)	compile	minor	`2.18.0` -> `2.19.0`
com.google.errorprone:error_prone_check_api (source)	compile	minor	`2.18.0` -> `2.19.0`
com.google.errorprone:error_prone_annotation (source)	compile	minor	`2.18.0` -> `2.19.0`

Release Notes

google/error-prone

`v2.19.0`: Error Prone 2.19.0

Compare Source

New Checkers:

Fixes issues: #956, #3504, #3654, #3703, #3731, #3737, #3760, #3779, #3796, #3809, #3813

Full Changelog: google/error-prone@v2.18.0...v2.19.0

If you want to rebase/retry this PR, check this box

Picnic-Bot · 2023-05-10T01:04:11Z

Suggested commit message:

Upgrade Error Prone 2.18.0 -> 2.19.1 (#621)

Resolves #622.

See:
- https://github.com/google/error-prone/releases/tag/v2.19.0
- https://github.com/google/error-prone/releases/tag/v2.19.1
- https://github.com/google/error-prone/compare/v2.18.0...v2.19.1
- https://github.com/PicnicSupermarket/error-prone/compare/v2.18.0-picnic-1...v2.19.1-picnic-1

Stephan202

I'll have a look at updating the fork. Locally I fixed the compilation issues, though there are some test failures to look into. Lastly, we should also drop StringCaseLocaleUsage.

rickie · 2023-05-10T06:08:04Z

Lastly, we should also drop StringCaseLocaleUsage.

I'll create a PR for that :).

Stephan202 · 2023-05-10T06:18:48Z

I'll create a PR for that :).

Doesn't it belong in this PR? 🤔

rickie · 2023-05-10T06:32:43Z

Lol, for some reason I thought I clicked the PSM PR, but yes we should haha.

Stephan202

Added one more commit. I created a new release of the fork, and the build now passes with -DskipTests on JDK 17. There are still test issues, which I'll look into next.

Stephan202 · 2023-05-10T07:39:11Z

error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/StringCaseLocaleUsage.java

-// XXX: Also flag `String::toLowerCase` and `String::toUpperCase` method references. For these cases
-// the suggested fix should introduce a lambda expression with a parameter of which the name does
-// not coincide with the name of an existing variable name. Such functionality should likely be
-// introduced in a utility class.


I added an entry to my local list; ideally we do still pick this up.

github-actions · 2023-05-10T08:25:16Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202

Added a commit. The build and tests now pass on JDK 17 and 20, but the JDK 11 is broken due to google/error-prone#3895.

github-actions · 2023-05-10T08:50:59Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-05-10T08:55:41Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202

Added a commit to fix the JDK 11 build. But given that these changes will break Refaster template compatibility with Error Prone 2.18.0 (due to serialization format changes), while users may not upgrade to Error Prone 2.19.0 due to google/error-prone#3895, I'm somewhat torn about the speed with which we should merge this PR 🤔

Stephan202 · 2023-05-10T09:03:16Z

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/BugCheckerRules.java

    @AfterTemplate
+    @CanIgnoreReturnValue
    BugCheckerRefactoringTestHelper after(BugCheckerRefactoringTestHelper helper) {
      return helper;
    }


It might be nice to open a PR upstream to skip suggesting @CanIgnoreReturnValue on @AfterTemplate. After all, such methods are not really meant to be invoked.

I'm totally up for that, will create it tomorrow morning 🦺.

Consider first checking the internal upgrade PR; as I mention there, there are a bunch of other (non-Refaster) cases in which adding @CanIgnoreReturnValue also doesn't really make sense.

Stephan202 · 2023-05-10T09:03:58Z

...support/src/main/java/tech/picnic/errorprone/refaster/AnnotatedCompositeCodeTransformer.java

            getDescription(delegate))
+        .overrideSeverity(overrideSeverity(getSeverity(delegate), context))


PItest warns about this call not being covered, but that's because the tests are in another module. If I drop this line then RefasterTest does fail.

Stephan202

Added a commit to upgrade to Error Prone 2.19.1, which comes with a fix for google/error-prone#3895.

One thing we should perhaps do (in a separate PR) is document that Error Prone Support's Refaster rules are only compatible with the version of Error Prone against which they're compiled. Ideally we document that version on the website. 🤔

github-actions · 2023-05-10T20:59:13Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Picnic-Bot · 2023-05-11T01:06:21Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

github-actions · 2023-05-12T07:35:03Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie

Nice changes! Besides the introduced CanIgnoreReturnValue it LGTM. Have code working for excluding Refaster rules but will definitely first check the internal PR.

rickie · 2023-05-12T08:10:17Z

Should we add one of the keywords like Closes or Fixes #622 to the commit message?

rickie · 2023-05-13T15:45:55Z

Filed: PicnicSupermarket/error-prone#60.

Do we add XXX references when I open the PR upstream and merge then? WDYT?

github-actions · 2023-05-13T15:48:07Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202 · 2023-05-14T14:49:22Z

Rebased. Will merge once built. Decided to leave the @CanIgnoreReturnValue as-is, in favour of a @Suppresswarning. We should not forget to drop them if/when an upstream PR to skip Refaster template methods is merged and released.

github-actions · 2023-05-14T14:50:57Z

Surviving mutants in this change: 1
Killed mutants in this change: 1

class	surviving	killed
🧟`tech.picnic.errorprone.refaster.AnnotatedCompositeCodeTransformer`	1	0
🎉`tech.picnic.errorprone.refaster.runner.Refaster`	0	1

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

sonarqubecloud · 2023-05-14T14:51:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication

Picnic-Bot added the dependencies label May 10, 2023

Picnic-Bot requested review from rickie and Stephan202 May 10, 2023 01:03

Stephan202 reviewed May 10, 2023

View reviewed changes

rickie mentioned this pull request May 10, 2023

Version 0.10.0 seems to be incompatible with Error Prone 2.19.0. #622

Closed

2 tasks

Stephan202 reviewed May 10, 2023

View reviewed changes

Stephan202 mentioned this pull request May 10, 2023

HidingField: NoSuchMethodError: com.sun.tools.javac.util.List com.sun.tools.javac.code.Symbol$TypeSymbol.getEnclosedElements() google/error-prone#3895

Closed

Stephan202 changed the title ~~Upgrade version.error-prone-orig 2.18.0 -> 2.19.0~~ Upgrade version.error-prone-orig 2.18.0 -> 2.19.1 May 10, 2023

Stephan202 added this to the 0.11.0 milestone May 10, 2023

Stephan202 approved these changes May 10, 2023

View reviewed changes

rickie force-pushed the renovate/version.error-prone-orig branch from 3d79983 to 0c7dbca Compare May 12, 2023 07:33

rickie approved these changes May 12, 2023

View reviewed changes

rickie force-pushed the renovate/version.error-prone-orig branch from 0c7dbca to 8e97904 Compare May 13, 2023 15:46

Picnic-Bot and others added 2 commits May 14, 2023 16:49

Upgrade version.error-prone-orig 2.18.0 -> 2.19.0

ed44740

Drop StringCaseLocaleUsage check

a9cb13f

Stephan202 added 5 commits May 14, 2023 16:49

Resolve build issues

ea721e2

Fix the build

447aa24

Enable new non-default flags

db74304

JDK 11 fix

4a367c9

Upgrade to 2.19.1

78264c3

Stephan202 force-pushed the renovate/version.error-prone-orig branch from 8e97904 to 78264c3 Compare May 14, 2023 14:49

Stephan202 merged commit 08e55fd into master May 14, 2023

Stephan202 deleted the renovate/version.error-prone-orig branch May 14, 2023 15:01

Stephan202 changed the title ~~Upgrade version.error-prone-orig 2.18.0 -> 2.19.1~~ Upgrade Error Prone 2.18.0 -> 2.19.1 May 14, 2023

Stephan202 mentioned this pull request May 25, 2023

ErrorProneInjector incorrectly picks up the no-args constructor google/error-prone#3931

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Error Prone 2.18.0 -> 2.19.1 #621

Upgrade Error Prone 2.18.0 -> 2.19.1 #621

Picnic-Bot commented May 10, 2023

Picnic-Bot commented May 10, 2023 •

edited by Stephan202

Loading

Stephan202 left a comment

rickie commented May 10, 2023

Stephan202 commented May 10, 2023

rickie commented May 10, 2023

Stephan202 left a comment •

edited

Loading

Stephan202 May 10, 2023

github-actions bot commented May 10, 2023

Stephan202 left a comment

github-actions bot commented May 10, 2023

github-actions bot commented May 10, 2023

Stephan202 left a comment

Stephan202 May 10, 2023

rickie May 11, 2023

Stephan202 May 11, 2023

Stephan202 May 10, 2023

Stephan202 left a comment

github-actions bot commented May 10, 2023

Picnic-Bot commented May 11, 2023

github-actions bot commented May 12, 2023

rickie left a comment

rickie commented May 12, 2023

rickie commented May 13, 2023

github-actions bot commented May 13, 2023

Stephan202 commented May 14, 2023

github-actions bot commented May 14, 2023

sonarqubecloud bot commented May 14, 2023

		getDescription(delegate))
		.overrideSeverity(overrideSeverity(getSeverity(delegate), context))

Upgrade Error Prone 2.18.0 -> 2.19.1 #621

Upgrade Error Prone 2.18.0 -> 2.19.1 #621

Conversation

Picnic-Bot commented May 10, 2023

Release Notes

v2.19.0: Error Prone 2.19.0

Picnic-Bot commented May 10, 2023 • edited by Stephan202 Loading

Stephan202 left a comment

Choose a reason for hiding this comment

rickie commented May 10, 2023

Stephan202 commented May 10, 2023

rickie commented May 10, 2023

Stephan202 left a comment • edited Loading

Choose a reason for hiding this comment

Stephan202 May 10, 2023

Choose a reason for hiding this comment

github-actions bot commented May 10, 2023

Stephan202 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 10, 2023

github-actions bot commented May 10, 2023

Stephan202 left a comment

Choose a reason for hiding this comment

Stephan202 May 10, 2023

Choose a reason for hiding this comment

rickie May 11, 2023

Choose a reason for hiding this comment

Stephan202 May 11, 2023

Choose a reason for hiding this comment

Stephan202 May 10, 2023

Choose a reason for hiding this comment

Stephan202 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 10, 2023

Picnic-Bot commented May 11, 2023

Edited/Blocked Notification

github-actions bot commented May 12, 2023

rickie left a comment

Choose a reason for hiding this comment

rickie commented May 12, 2023

rickie commented May 13, 2023

github-actions bot commented May 13, 2023

Stephan202 commented May 14, 2023

github-actions bot commented May 14, 2023

sonarqubecloud bot commented May 14, 2023

`v2.19.0`: Error Prone 2.19.0

Picnic-Bot commented May 10, 2023 •

edited by Stephan202

Loading

Stephan202 left a comment •

edited

Loading