-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend PrimitiveRules
Refaster rule collection
#608
Conversation
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a commit with a think I spotted.
Nice improvements, funny that they have literally the same methods there.
Looks good. No mutations were possible for these changes. |
97d9e81
to
0cfc32d
Compare
Looks good. No mutations were possible for these changes. |
Tweak LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Could consider looking at all the to/fromByteBuffer
functions in the future as well, as they state themselves Arguably, it's preferable to use ByteBuffer
, but that's less straightforward 😄
Assorted methods and constants exposed by Guava's `com.google.common.primitives.*` types are now replaced with their JDK equivalents. While there, also update the parameter types of some existing `@AfterTemplate` methods, resolving an inconsistency flagged by @knutwannheden.
0cfc32d
to
6ecdd4a
Compare
Looks good. No mutations were possible for these changes. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Assorted methods and constants exposed by Guava's `com.google.common.primitives.*` types are now replaced with their JDK equivalents. While there, also update the parameter types of some existing `@AfterTemplate` methods, resolving an inconsistency flagged by @knutwannheden.
Suggested commit message: