Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PrimitiveRules Refaster rule collection #608

Merged
merged 2 commits into from
May 3, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented May 1, 2023

Suggested commit message:

Extend `PrimitiveRules` Refaster rule collection (#608)

Assorted methods and constants exposed by Guava's
`com.google.common.primitives.*` types are now replaced with their JDK
equivalents.

While there, also update the parameter types of some existing `@AfterTemplate`
methods, resolving an inconsistency flagged by @knutwannheden.

@Stephan202 Stephan202 added this to the 0.10.0 milestone May 1, 2023
@Stephan202 Stephan202 requested a review from rickie May 1, 2023 06:50
@github-actions
Copy link

github-actions bot commented May 1, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit with a think I spotted.

Nice improvements, funny that they have literally the same methods there.

@github-actions
Copy link

github-actions bot commented May 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/extend-primitive-rules branch from 97d9e81 to 0cfc32d Compare May 2, 2023 08:16
@github-actions
Copy link

github-actions bot commented May 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Tweak LGTM!

Copy link
Contributor

@Venorcis Venorcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Could consider looking at all the to/fromByteBuffer functions in the future as well, as they state themselves Arguably, it's preferable to use ByteBuffer, but that's less straightforward 😄

@Stephan202
Copy link
Member Author

Ah, nice catch w.r.t. this indeed. I looked only for explicit references to "Java" and "JDK". One thing that I'm not so sure about in this case, is that for the dual there is no "acceptable" alternative, which might make the rewrite slightly awkward 🤔.

Stephan202 and others added 2 commits May 3, 2023 14:27
Assorted methods and constants exposed by Guava's
`com.google.common.primitives.*` types are now replaced with their JDK
equivalents.

While there, also update the parameter types of some existing `@AfterTemplate`
methods, resolving an inconsistency flagged by @knutwannheden.
@rickie rickie force-pushed the sschroevers/extend-primitive-rules branch from 0cfc32d to 6ecdd4a Compare May 3, 2023 12:27
@github-actions
Copy link

github-actions bot commented May 3, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 52245c6 into master May 3, 2023
@rickie rickie deleted the sschroevers/extend-primitive-rules branch May 3, 2023 12:39
philleonard pushed a commit that referenced this pull request May 26, 2023
Assorted methods and constants exposed by Guava's
`com.google.common.primitives.*` types are now replaced with their JDK
equivalents.

While there, also update the parameter types of some existing `@AfterTemplate`
methods, resolving an inconsistency flagged by @knutwannheden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants