Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable SuggestedFixRules tests #581

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Fix and enable SuggestedFixRules tests #581

merged 2 commits into from
Apr 13, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 13, 2023 •
edited
Loading

Yeah... (noticed while rebasing the website branch: it's build fails on the unknown Suggestions type.

Suggested commit message:

Fix and enable `SuggestedFixRules` tests (#581)

@Stephan202 Stephan202 requested review from oxkitsune and rickie April 13, 2023 11:26
@Stephan202 Stephan202 added this to the 0.10.0 milestone Apr 13, 2023
@Stephan202 Stephan202 marked this pull request as ready for review April 13, 2023 11:26
@Stephan202 Stephan202 force-pushed the sschroevers/fix-suggested-fix-rules-test branch from 36cb114 to 730109a Compare April 13, 2023 11:30
@Stephan202
Copy link
Member Author

(Copilot not as accurate as expected ;).)

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member

rickie commented Apr 13, 2023

Aiii this is painful 😅.

rickie
rickie approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@rickie rickie added the documentation A documentation update label Apr 13, 2023
@rickie rickie merged commit 8ace5b7 into master Apr 13, 2023
@rickie rickie deleted the sschroevers/fix-suggested-fix-rules-test branch April 13, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@oxkitsune oxkitsune oxkitsune approved these changes

Assignees
No one assigned
Labels
documentation A documentation update
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @oxkitsune