-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CodeQL security vulnerability analysis #573
Conversation
9005796
to
bb73e5d
Compare
error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/DirectReturn.java
Fixed
Show fixed
Hide fixed
Looks good. No mutations were possible for these changes. |
1 similar comment
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
Kudos, SonarCloud Quality Gate passed! |
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super neat stuff 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a tiny commit. Nice commit history, really useful to go through.
Agree that using a cron is nice for this :).
.github/workflows/codeql.yml
Outdated
@@ -0,0 +1,44 @@ | |||
# Analyzes the code base using Github's default CodeQL query database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Analyzes the code base using Github's default CodeQL query database. | |
# Analyzes the code base using GitHub's default CodeQL query database. |
While there, tweak some indentation in another GitHub Actions workflow file.
This reverts commit 512648b.
3d96164
to
d116ef4
Compare
Looks good. No mutations were possible for these changes. |
1 similar comment
Looks good. No mutations were possible for these changes. |
Tnx for the review! |
Suggested commit message:
See the commit history for some things I tried and tested. I temporarily introduced code that referenced MD5 to trigger a warning. That code was flagged at the relevant source code line (see collapsed message). Here one can see the resolved violation.