Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CodeQL security vulnerability analysis #573

Merged
merged 16 commits into from
Apr 15, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 8, 2023

Suggested commit message:

Introduce CodeQL security vulnerability analysis (#573)

See https://codeql.github.com

See the commit history for some things I tried and tested. I temporarily introduced code that referenced MD5 to trigger a warning. That code was flagged at the relevant source code line (see collapsed message). Here one can see the resolved violation.

@Stephan202 Stephan202 force-pushed the sschroevers/introduce-codeql-analysis branch from 9005796 to bb73e5d Compare April 8, 2023 14:06
@Stephan202 Stephan202 added this to the 0.10.0 milestone Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 requested a review from rickie April 8, 2023 17:10
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@oxkitsune oxkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat stuff 🚀

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a tiny commit. Nice commit history, really useful to go through.

Agree that using a cron is nice for this :).

@@ -0,0 +1,44 @@
# Analyzes the code base using Github's default CodeQL query database.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Analyzes the code base using Github's default CodeQL query database.
# Analyzes the code base using GitHub's default CodeQL query database.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Apr 15, 2023
@rickie rickie force-pushed the sschroevers/introduce-codeql-analysis branch from 3d96164 to d116ef4 Compare April 15, 2023 15:19
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Tnx for the review!

@rickie rickie changed the title Introduce CodeQL analysis Introduce CodeQL security vulnerability analysis Apr 15, 2023
@rickie rickie merged commit 9ddd91a into master Apr 15, 2023
@rickie rickie deleted the sschroevers/introduce-codeql-analysis branch April 15, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants