Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven-release-plugin 2.5.3 -> 3.0.0 #540

Merged

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
org.apache.maven.plugins:maven-release-plugin build major 2.5.3 -> 3.0.0

  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Mar 21, 2023

Suggested commit message:

Upgrade maven-release-plugin 2.5.3 -> 3.0.0 (#540)

See:
- https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRELEASE%20AND%20fixVersion%20%3E%202.5.3%20AND%20fixVersion%20%3C%3D%203.0.0
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M1
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M2
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M3
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M4
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M5
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M6
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0-M7
- https://github.com/apache/maven-release/releases/tag/maven-release-3.0.0
- https://github.com/apache/maven-release/compare/maven-release-2.5.3...maven-release-3.0.0

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

2 similar comments
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added this to the 0.9.0 milestone Mar 21, 2023
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/org.apache.maven.plugins-maven-release-plugin-3.x branch from babdda3 to dedb1bd Compare March 21, 2023 06:53
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/org.apache.maven.plugins-maven-release-plugin-3.x branch from 21ca4ce to dedb1bd Compare March 21, 2023 07:10
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the suggested commit message.

Ran some tests: managed to successfully upload a release to an OSSRH staging repository (and then dropped the result). I did also try the new signTag option, but that didn't readily work. Not spending more time on that right now.

Comment on lines +1069 to 1070
<preparationProfiles>release</preparationProfiles>
<releaseProfiles>release</releaseProfiles>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way any Javadoc and GPG issues can already be surfaced during due release:prepare phase, instead of the release:perform phase.

@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rickie rickie force-pushed the renovate/org.apache.maven.plugins-maven-release-plugin-3.x branch from dedb1bd to 33174a1 Compare March 22, 2023 17:53
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the renovate/org.apache.maven.plugins-maven-release-plugin-3.x branch from 33174a1 to 22b30b0 Compare March 27, 2023 06:21
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the renovate/org.apache.maven.plugins-maven-release-plugin-3.x branch from 22b30b0 to a338935 Compare March 27, 2023 06:32
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie changed the title Upgrade org.apache.maven.plugins:maven-release-plugin 2.5.3 -> 3.0.0 Upgrade maven-release-plugin 2.5.3 -> 3.0.0 Mar 27, 2023
@rickie rickie merged commit 973d3c3 into master Mar 27, 2023
@rickie rickie deleted the renovate/org.apache.maven.plugins-maven-release-plugin-3.x branch March 27, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants