Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JDKs used by GitHub Actions builds #521

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Upgrade JDKs used by GitHub Actions builds #521

merged 2 commits into from
Mar 15, 2023

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Mar 4, 2023 •
edited
Loading

Suggested commit message:

Upgrade JDKs used by GitHub Actions builds (#521)

Additionally:
- Update the example version numbers mentioned in the issue template.
- Drop some redundant whitespace from `SourceCodeTest` test code.
- Sort some compiler arguments.

See:
- https://www.oracle.com/java/technologies/javase/11-0-17-relnotes.html
- https://www.oracle.com/java/technologies/javase/11-0-18-relnotes.html
- https://www.oracle.com/java/technologies/javase/17-0-5-relnotes.html
- https://www.oracle.com/java/technologies/javase/17-0-6-relnotes.html
- https://www.oracle.com/java/technologies/javase/19-0-1-relnotes.html
- https://www.oracle.com/java/technologies/javase/19-0-2-relnotes.html

@Stephan202 Stephan202 added this to the 0.9.0 milestone Mar 4, 2023
@Stephan202 Stephan202 requested a review from rickie March 4, 2023 13:17
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie added chore A task not related to code (build, formatting, process, ...) dependencies and removed chore A task not related to code (build, formatting, process, ...) labels Mar 4, 2023
@Stephan202 Stephan202 force-pushed the sschroevers/upgrade-build-jdks branch from 440bb8a to 74af403 Compare March 5, 2023 10:41
@Stephan202
Copy link
Member Author

(Added one more commit.)

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202
Stephan202 commented Mar 15, 2023
View reviewed changes
pom.xml Outdated
Comment on lines 1112 to 1113
<configurationParameters>junit.jupiter.execution.parallel.config.strategy=dynamic
junit.jupiter.execution.parallel.enabled=true
junit.jupiter.execution.parallel.mode.default = concurrent</configurationParameters>
<configurationParameters>junit.jupiter.execution.parallel.enabled=true
junit.jupiter.execution.parallel.mode.default=concurrent</configurationParameters>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added these changes to #532; let's merge that PR first.

rickie
rickie approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Didn't read the release notes too thoroughly. Let's merge the other PR first indeed 😄.

@rickie rickie requested a review from werli March 15, 2023 07:38
werli
werli approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@werli werli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Stephan202 💪

.github/workflows/build.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably for another PR: The Github actions could also be upgraded. See:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm certain that Renovate opened PRs for that 🤔. Can take a closer look at this ~soon.

@rickie rickie force-pushed the sschroevers/upgrade-build-jdks branch from baec937 to 7db9ab5 Compare March 15, 2023 07:58
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the sschroevers/upgrade-build-jdks branch from 7db9ab5 to 4764ae7 Compare March 15, 2023 12:04
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie merged commit 06c8b16 into master Mar 15, 2023
@rickie rickie deleted the sschroevers/upgrade-build-jdks branch March 15, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@werli werli werli approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @werli @rickie