Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 #515

Picnic-Bot · 2023-03-01T02:01:08Z

This PR contains the following updates:

Package	Type	Update	Change
org.apache.maven.plugins:maven-compiler-plugin	build	minor	`3.10.1` -> `3.11.0`

If you want to rebase/retry this PR, check this box

Picnic-Bot · 2023-03-01T02:02:19Z

Suggested commit message:

Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 (#515)

See:
- https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.11.0
- https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.12.0
- https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.12.1
- https://github.com/apache/maven-compiler-plugin/compare/maven-compiler-plugin-3.10.1...maven-compiler-plugin-3.12.1

github-actions · 2023-03-01T02:03:32Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-03-01T02:03:44Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-03-01T08:26:29Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202

Added a commit with some suggestions. With these changes, running with -Dverification.skip logs:

[WARNING] The property failOnWarning is set to true, but showWarnings is set to false.
[WARNING] With compiler's warnings silenced the failOnWarning has no effect.

Didn't see a nice/proper/robust way around that yet.

Separately for that, I noticed that building against the Error Prone fork causes an error if run from within a submodule. That's surprising and requires further investigation. (EOD earliest; meetings now.)

Stephan202 · 2023-03-01T16:05:18Z

Separately for that, I noticed that building against the Error Prone fork causes an error if run from within a submodule. That's surprising and requires further investigation.

This issue also breaks the -pl flag. Part of the problem is unrelated to this PR and already got broken by d1f5133; another part does seem to be broken by the changes in this PR. Will look more closely at that.

Picnic-Bot · 2023-03-02T02:01:01Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

github-actions · 2023-12-19T20:13:22Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Stephan202 · 2023-12-19T20:13:32Z

I rebased and upgraded to version 3.12.0; all-in-all this upgrade now makes for a nice cleanup.

The only open point is the issue with building a subset of the modules against the fork. I don't want to further block this PR on that; will have a small final look to see whether I can find a fix.

Stephan202

K, upon retesting I conclude that the issue with the partial builds using the Error Prone fork are not new at all; but with -pl and by cd-ing into the subdirectory I can reproduce the issue against master. @rickie I think we can merge this one, finally :)

rickie · 2023-12-24T18:59:56Z

Rebased and resolved conflict, will take a look tomorrow.

github-actions · 2023-12-24T19:03:36Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

github-actions · 2023-12-25T12:05:00Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie · 2023-12-25T12:56:39Z

pom.xml

                    <configuration>
-                        <!-- XXX: MCOMPILER-503: The plugin constructs a highly


Nice, we can archive this one: https://github.com/PicnicSupermarket/maven-compiler-plugin-issue-503

Good once; done. ✔️

rickie · 2023-12-25T13:01:36Z

pom.xml

                                </path>
                                <path>
                                    <groupId>${project.groupId}</groupId>
                                    <artifactId>refaster-runner</artifactId>
-                                    <version>${project.version}</version>
                                </path>
                            </annotationProcessorPaths>
                        </configuration>


IIUC we can now drop this one: https://github.com/PicnicSupermarket/error-prone-support/pull/515/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R1596, right?

Hmm, that one counteracts the opposite config on line 911. This way warnings are disabled if -Dverification.skip is specified.

Stephan202 · 2023-12-26T09:40:35Z

I updated the PR to include the upgrade to version 3.12.1.

sonarqubecloud · 2023-12-26T09:41:05Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2023-12-26T09:43:03Z

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie · 2023-12-26T11:04:24Z

Nice improvements. Cool to see so many improvements in these releases 😄. Makes the pom.xml a lot more straightforward.

Stephan202 · 2024-01-10T18:49:55Z

For future reference: this cleanup triggered a bug in IntelliJ IDEA; see #958 for details.

Picnic-Bot added the dependencies label Mar 1, 2023

Picnic-Bot requested review from rickie and Stephan202 March 1, 2023 02:01

Stephan202 reviewed Mar 1, 2023

View reviewed changes

Stephan202 added this to the 0.9.0 milestone Mar 1, 2023

rickie modified the milestones: 0.9.0, 0.10.0 Mar 30, 2023

rickie modified the milestones: 0.10.0, 0.11.0 Apr 26, 2023

Stephan202 modified the milestones: 0.11.0, 0.12.0 May 14, 2023

Stephan202 modified the milestones: 0.12.0, 0.13.0 Jun 21, 2023

rickie modified the milestones: 0.13.0, 0.14.0 Aug 25, 2023

rickie modified the milestones: 0.14.0, 0.15.0 Oct 4, 2023

Stephan202 force-pushed the renovate/org.apache.maven.plugins-maven-compiler-plugin-3.x branch from 77ba138 to cea6018 Compare December 19, 2023 20:09

Stephan202 changed the title ~~Upgrade org.apache.maven.plugins:maven-compiler-plugin 3.10.1 -> 3.11.0~~ Upgrade org.apache.maven.plugins:maven-compiler-plugin 3.10.1 -> 3.12.0 Dec 19, 2023

Stephan202 approved these changes Dec 19, 2023

View reviewed changes

rickie force-pushed the renovate/org.apache.maven.plugins-maven-compiler-plugin-3.x branch from cea6018 to 16a9839 Compare December 24, 2023 18:59

Stephan202 mentioned this pull request Dec 24, 2023

Add rewrite-templating annotation processor to also produce OpenRewrite recipes #925

Merged

3 tasks

Picnic-Bot and others added 3 commits December 25, 2023 13:01

Upgrade org.apache.maven.plugins:maven-compiler-plugin 3.10.1 -> 3.11.0

f459b72

Suggestions

8651265

Upgrade to 3.12.0

38a0767

rickie force-pushed the renovate/org.apache.maven.plugins-maven-compiler-plugin-3.x branch from 16a9839 to 38a0767 Compare December 25, 2023 12:01

rickie reviewed Dec 25, 2023

View reviewed changes

Upgrade to 3.12.1

d112b9b

Stephan202 changed the title ~~Upgrade org.apache.maven.plugins:maven-compiler-plugin 3.10.1 -> 3.12.0~~ Upgrade org.apache.maven.plugins:maven-compiler-plugin 3.10.1 -> 3.12.1 Dec 26, 2023

rickie approved these changes Dec 26, 2023

View reviewed changes

rickie merged commit 3578a8c into master Dec 26, 2023
16 checks passed

rickie deleted the renovate/org.apache.maven.plugins-maven-compiler-plugin-3.x branch December 26, 2023 11:04

Stephan202 mentioned this pull request Jan 10, 2024

Work around IntelliJ IDEA bug IDEA-342187 #958

Merged

Stephan202 changed the title ~~Upgrade org.apache.maven.plugins:maven-compiler-plugin 3.10.1 -> 3.12.1~~ Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 Feb 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 #515

Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 #515

Picnic-Bot commented Mar 1, 2023

Picnic-Bot commented Mar 1, 2023 •

edited by Stephan202

Loading

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

Stephan202 left a comment

Stephan202 commented Mar 1, 2023

Picnic-Bot commented Mar 2, 2023

github-actions bot commented Dec 19, 2023

Stephan202 commented Dec 19, 2023

Stephan202 left a comment

rickie commented Dec 24, 2023

github-actions bot commented Dec 24, 2023

github-actions bot commented Dec 25, 2023

rickie Dec 25, 2023

Stephan202 Dec 25, 2023

rickie Dec 25, 2023

Stephan202 Dec 25, 2023

Stephan202 commented Dec 26, 2023

sonarqubecloud bot commented Dec 26, 2023

github-actions bot commented Dec 26, 2023

rickie commented Dec 26, 2023

Stephan202 commented Jan 10, 2024

		<configuration>
		<!-- XXX: MCOMPILER-503: The plugin constructs a highly

Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 #515

Upgrade maven-compiler-plugin 3.10.1 -> 3.12.1 #515

Conversation

Picnic-Bot commented Mar 1, 2023

Picnic-Bot commented Mar 1, 2023 • edited by Stephan202 Loading

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

github-actions bot commented Mar 1, 2023

Stephan202 left a comment

Choose a reason for hiding this comment

Stephan202 commented Mar 1, 2023

Picnic-Bot commented Mar 2, 2023

Edited/Blocked Notification

github-actions bot commented Dec 19, 2023

Stephan202 commented Dec 19, 2023

Stephan202 left a comment

Choose a reason for hiding this comment

rickie commented Dec 24, 2023

github-actions bot commented Dec 24, 2023

github-actions bot commented Dec 25, 2023

rickie Dec 25, 2023

Choose a reason for hiding this comment

Stephan202 Dec 25, 2023

Choose a reason for hiding this comment

rickie Dec 25, 2023

Choose a reason for hiding this comment

Stephan202 Dec 25, 2023

Choose a reason for hiding this comment

Stephan202 commented Dec 26, 2023

sonarqubecloud bot commented Dec 26, 2023

Quality Gate passed

github-actions bot commented Dec 26, 2023

rickie commented Dec 26, 2023

Stephan202 commented Jan 10, 2024

Picnic-Bot commented Mar 1, 2023 •

edited by Stephan202

Loading