Enable additional maven-enforcer-plugin rules
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Feb 4, 2023
| <banDuplicatePomDependencyVersions /> | ||
| <!-- XXX: Enable this rule once it no longer | ||
| "downloads the internet". See | ||
| https://issues.apache.org/jira/browse/MENFORCER-467. |
There was a problem hiding this comment.
Link for easy clicking.
1 task
|
Looks good. No mutations were possible for these changes. |
rickie
reviewed
Feb 6, 2023
| <dependencyConvergence /> | ||
| <enforceBytecodeVersion> |
chamil-prabodha
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Some of the rules are documented here and might be useful to link it here :)
https://www.mojohaus.org/extra-enforcer-rules/
rickie
force-pushed
the
sschroevers/extra-maven-enforcer-rules
branch
from
106d15d to
0fc7054
Compare
|
Looks good. No mutations were possible for these changes. |
rickie
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message: