Document MonoFlatMapToFlux Refaster rule limitation
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. No mutations were possible for these changes. |
rickie
approved these changes
Jan 24, 2023
| @@ -474,6 +474,11 @@ Flux<S> after( | |||
| * Flux}. | |||
| */ | |||
| abstract static class MonoFlatMapToFlux<T, S> { | |||
| // XXX: I'd be more expressive if this `@Placeholder` were replaced with a `Function<? super T, | |||
There was a problem hiding this comment.
Suggested change
| // XXX: I'd be more expressive if this `@Placeholder` were replaced with a `Function<? super T, | |
| // XXX: It'd be more expressive if this `@Placeholder` were replaced with a `Function<? super T, |
There was a problem hiding this comment.
Maybe writing it out is also fine :).
|
Looks good. No mutations were possible for these changes. |
werli
approved these changes
Jan 24, 2023
rickie
force-pushed
the
sschroevers/document-MonoFlatMapToFlux-limitation
branch
from
ea3b285 to
da82ae0
Compare
|
Change LGTM :) |
|
Looks good. No mutations were possible for these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
For those wishing to attach a debugger: the type against which Refaster matches is retrieved here. I suppose that at the place where the binding is stored, we can inspect the lambda expression/method reference and perhaps construct a more accurate type, but that's a rabbit hole I'd rather not jump in right now.