Code

Introduce FluxImplicitBlock check#472

Code

Merged

rickie merged 32 commits intoPicnicSupermarket:masterPicnicSupermarket/error-prone-support:masterfrom benhalasi:benhalasi/introduce-avoid-accidental-blocking-rulesbenhalasi/error-prone-support:benhalasi/introduce-avoid-accidental-blocking-rulesCopy head branch name to clipboardFeb 20, 2023

+282

Commits

Commits on Feb 20, 2023

• Introduce Flux.to{Stream,Iterable} Refaster rules

  Show description for ee5e33e
  

  benhalasi

  authored and

  rickie

  committed
  ee5e33e

• fix: Method return type can use a more specific type to convey more information to callers

  

  benhalasi

  authored and

  rickie

  committed
  a125e0b

• checkstyle

  

  benhalasi

  authored and

  rickie

  committed
  c9d1d34

• Revert all "Introduce Flux.to{Stream,Iterable} Refaster rules" connected commits

  

  benhalasi

  authored and

  rickie

  committed
  d4626ad

• Introduce ImplicitBlockingFluxOperation check (PicnicSupermarket#468)

  

  benhalasi

  authored and

  rickie

  committed
  ed4bc82

• checkstyle and javadocs

  

  benhalasi

  authored and

  rickie

  committed
  f94bd87

• checkstyle: new-line at the start of a block

  Show description for 030f091
  

  benhalasi

  and

  rickie

  committed
  030f091

• convention: refering BugCheckerRefactoringTestHelper.TestMode through BugCheckerRefactoringTestHelper

  Show description for 14165d6
  

  benhalasi

  and

  rickie

  committed
  14165d6

• Suggestions

  rickie

  committed
  bfcc395

• Resolve MethodMatchers.MethodClassMatcher deprecation

  

  benhalasi

  authored and

  rickie

  committed
  b160ab3

• Suggestions 2

  rickie

  committed
  408a968

• Apply suggested changes.

  Show description for 73ff418
  

  benhalasi

  authored and

  rickie

  committed
  73ff418

• Refactor implementation for readability and resiliency

  Show description for 0343892
  

  benhalasi

  authored and

  rickie

  committed
  0343892

• Suggestions

  rickie

  committed
  c244042

• Drop semi-duplicate method and inline a method

  rickie

  committed
  7fc2527

• Use Types#isSubType in combination with MoreTypes DSL

  rickie

  committed
  ac931e4

• Discussed this with @Stephan202 :)

  rickie

  committed
  2f1e6da

• resolve replaceMethodInvocation method's assumptions with Optional

  

  benhalasi

  authored and

  rickie

  committed
  e97dde7

• implement helper class and verify that matcher only picks up Flux methods with it

  

  benhalasi

  authored and

  rickie

  committed
  54aa877

• javadoc for default constructor

  

  benhalasi

  authored and

  rickie

  committed
  8ff5b12

• kill NULL_RETURNS mutant

  

  benhalasi

  authored and

  rickie

  committed
  cf15383

• making tests fail when guava is introduced despite that's not allowed

  

  benhalasi

  authored and

  rickie

  committed
  22fb2dd

• formatting

  

  benhalasi

  authored and

  rickie

  committed
  0273b3f

• Suggestions

  rickie

  committed
  0ae778b

• Add missing imports

  rickie

  committed
  3e07247

• Suggestions and rename

  rickie

  committed
  b242c78

• Suggestions

  rickie

  committed
  c90c588

• Naming tweaks

  rickie

  committed
  4a3eb93

• Suggestions

  

  Stephan202

  authored and

  rickie

  committed
  c8afb35

• More accurate phrasing

  

  Stephan202

  authored and

  rickie

  committed
  db3be54

• Allow suggestion order changes in identification test, since the order is enforced by other tests.

  

  benhalasi

  authored and

  rickie

  committed
  4de090e

• s/ImplicitBlockingFlux/FluxImplicitBlock/

  rickie

  committed
  56067cb