Extend MonoIdentity Refaster rule
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By flagging expressions of the form `mono.flux().singleOrEmpty()`.
|
Looks good. No mutations were possible for these changes. |
rickie
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for two bite size PRs, but I've just now noticed one more case which wasn't covered in #465.
Mono#singleOrEmpty()has side-effects, but only if there is more than one element which by definition cannot occur after aMono#flux()call.I've checked again to see whether more expressions would qualify, however
Mono#single()andMono#last()don't qualify since they have side-effects when no element can be found.Suggested commit message