Upgrade Error Prone 2.17.0 -> 2.18.0

[Stephan202]

Suggested commit message:

Upgrade Error Prone 2.17.0 -> 2.18.0 (#455)

See:
- https://github.com/google/error-prone/releases/tag/v2.18.0
- https://github.com/google/error-prone/compare/v2.17.0...v2.18.0
- https://github.com/PicnicSupermarket/error-prone/compare/v2.17.0-picnic-1...v2.18.0-picnic-1

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[Picnic-Bot]

Suggested commit message:

Upgrade Error Prone 2.17.0 -> 2.18.0

[Stephan202]

To be sure: we can discuss enabling this, of course. Maybe I should just get used to it. Even so: the resultant changes also require careful null analysis.

[rickie]

I'm on the fence about this. Enabling this would result in better/easier readable code IMO. What concerns do you have with enabling this 👀? (Other than getting used to it 😉)

In any case, it would make sense to enable this in a separate PR (especially if we want to make the next internal PSM release).

[Stephan202]

What concerns do you have with enabling this 👀 (Other than getting used to it 😉 )

Well the question is whether it's just "getting used to", or that in some cases readability actually suffers. Separately from that it might force us to introduce additional explicit null checks, which would be plain awkward.

[rickie]

We could open a PR where we enable the check and go over the results and make a decision for EPS there? It is hard to reason about it now if we don't know how "bad" it'll be.

[Stephan202]

Draft PRs are free ;)

That said, I'd also like to see the arguments brought up during the internal discussion on this topic. 🧑‍🎓

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

[github-actions]

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.