Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AssertJ Core 3.23.1 -> 3.24.0 #448

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
org.assertj:assertj-core compile minor 3.23.1 -> 3.24.0

  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Jan 6, 2023

Suggested commit message:

Upgrade AssertJ Core 3.23.1 -> 3.24.0 (#448)

While there, use the new BOM.

See:
- https://assertj.github.io/doc/#assertj-core-release-notes
- https://github.com/joel-costigliola/assertj-core/compare/assertj-core-3.23.1...assertj-build-3.24.0

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to use the new BOM.

Likely we should also investigate use of assertj-guava

@Stephan202 Stephan202 added this to the 0.7.0 milestone Jan 6, 2023
@Stephan202
Copy link
Member

Also tweaked the suggested commit message.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rickie rickie force-pushed the renovate/org.assertj-assertj-core-3.x branch from 2979201 to 0b1b48c Compare January 6, 2023 07:48
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member

rickie commented Jan 6, 2023

Likely we should also investigate use of assertj-guava

That link leads to website that links to a GH repo that is a public archive though.

AssertJ Guava is hosted on github : https://github.com/joel-costigliola/assertj-guava.

However, it lives in AssertJ core.

But yes, there could be some interesting stuff in there :).

@rickie rickie changed the title Upgrade org.assertj:assertj-core 3.23.1 -> 3.24.0 Upgrade AssertJ Core 3.23.1 -> 3.24.0 Jan 6, 2023
@rickie rickie merged commit e9733f7 into master Jan 6, 2023
@rickie rickie deleted the renovate/org.assertj-assertj-core-3.x branch January 6, 2023 08:12
@Stephan202
Copy link
Member

However, it lives in AssertJ core.

The new BOM shows that they're split.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants