Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have apply-error-prone-suggestions.sh download JitPack-hosted artifacts #441

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Have apply-error-prone-suggestions.sh download JitPack-hosted artifacts #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apply-error-prone-suggestions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@
set -e -u -o pipefail

if [ "${#}" -gt 1 ]; then
echo "Usage: ./$(basename "${0}") [PatchChecks]"
echo "Usage: ${0} [PatchChecks]"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer assume that the script is executed from the directory in which it resides.

exit 1
fi

patchChecks=${1:-}

mvn clean test-compile fmt:format \
-s "$(dirname "${0}")/settings.xml" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix has downsides of its own: it overrides the user's settings.xml, which may contain other useful or even required settings. For Picnic devs it means that our Nexus deployment is bypassed, triggering one extra round of downloads.

The alternative is to move the settings.xml contents into a profile in the top-level pom.xml, but I seem to recall that Maven Central doesn't like that. (Or perhaps is does allow it when part of a profile? I'd have to check.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Setting up multiple repositories (esp. the order) and Using mirrors for repositories; as Picnic devs mirror everything anyway, could we instead just place repositories in the root of the pom (i.e. not in a profile)? Then we can also omit the settings.xml altogether.

To my understanding, this would behave the same as that the super pom defines a repository to Maven central, which is always included too.

-T 1.0C \
-Perror-prone \
-Perror-prone-fork \
Expand Down
2 changes: 1 addition & 1 deletion run-mutation-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
set -e -u -o pipefail

if [ "${#}" -gt 1 ]; then
echo "Usage: ./$(basename "${0}") [TargetTests]"
echo "Usage: ${0} [TargetTests]"
exit 1
fi

Expand Down