Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Checkstyle 10.5.0 -> 10.6.0 #435

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
com.puppycrawl.tools:checkstyle (source) build minor 10.5.0 -> 10.6.0

  • If you want to rebase/retry this PR, check this box

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

2 similar comments
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added this to the 0.7.0 milestone Jan 1, 2023
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickie also no suggested commit message here 🤔

Proposal:

Upgrade Checkstyle 10.5.0 -> 10.6.0 (#435)

See:
- https://checkstyle.sourceforge.io/releasenotes.html
- https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.6.0
- https://github.com/checkstyle/checkstyle/compare/checkstyle-10.5.0...checkstyle-10.6.0

@rickie
Copy link
Member

rickie commented Jan 2, 2023

Checked out the pods for Renovate and something is wrong there. Opened a thread in the team channel :).

@rickie
Copy link
Member

rickie commented Jan 2, 2023

Do we want to do something with the JavadocStyleCheck? Verifying the first sentence is proper punctuation and all sounds good to me.

@rickie rickie force-pushed the renovate/com.puppycrawl.tools-checkstyle-10.x branch from 3d209b7 to 672a141 Compare January 2, 2023 08:20
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie changed the title Upgrade com.puppycrawl.tools:checkstyle 10.5.0 -> 10.6.0 Upgrade Checkstyle 10.5.0 -> 10.6.0 Jan 2, 2023
@rickie rickie merged commit d7c86c4 into master Jan 2, 2023
@rickie rickie deleted the renovate/com.puppycrawl.tools-checkstyle-10.x branch January 2, 2023 08:33
@Stephan202
Copy link
Member

Do we want to do something with the JavadocStyleCheck? Verifying the first sentence is proper punctuation and all sounds good to me.

Yes, SGTM too, so go for it :)

(Eventually we should auto-fix such thing with Error Prone, but this is a low-effort first step.)

@rickie
Copy link
Member

rickie commented Jan 6, 2023

Opened a PR: #451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants