Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Error Prone fork v2.16-picnic-1 -> v2.16-picnic-2 #410

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Upgrade Error Prone fork v2.16-picnic-1 -> v2.16-picnic-2 #410

merged 1 commit into from
Dec 13, 2022

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 13, 2022 •
edited
Loading

Suggested commit message:

Upgrade Error Prone fork v2.16-picnic-1 -> v2.16-picnic-2 (#410)

See:
- https://github.com/PicnicSupermarket/error-prone/releases/tag/v2.16-picnic-2
- https://github.com/PicnicSupermarket/error-prone/compare/v2.16-picnic-1...v2.16-picnic-2

@Stephan202 Stephan202 added this to the 0.7.0 milestone Dec 13, 2022
@Stephan202
Copy link
Member Author

For the past ~24 hours all builds have failed while trying to fetch version v2.16-picnic-1. I'm not sure what that's about and don't really have time to investigate, so I hope that this upgrade will just make it go away 👀.

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 requested a review from rickie December 13, 2022 06:06
@Stephan202
Copy link
Member Author

Sometimes the stupid things work. Great :D

@Stephan202 Stephan202 mentioned this pull request Dec 13, 2022
Merged
Badbond
Badbond approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Badbond Badbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rickie rickie merged commit 8d0f1d7 into master Dec 13, 2022
@rickie rickie deleted the sschroevers/upgrade-error-prone-fork branch December 13, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Badbond Badbond Badbond approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @Badbond @rickie