Update website styling and add Google site verification #408
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <img src="/assets/images/[email protected]" alt="Picnic Logo" id="logo"/> | ||
|
|
||
| <p> | ||
| Copyright © 2017-2022 Picnic Technologies BV | ||
| </p> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,15 +4,15 @@ | |
| <link rel="icon" type="image/png" sizes="16x16" href="/assets/images/favicon-16x16.png"> | ||
| <link rel="manifest" href="/assets/images/site.webmanifest"> | ||
| <link rel="mask-icon" href="/assets/images/safari-pinned-tab.svg" color="#5bbad5"> | ||
| <meta name="msapplication-TileColor" content="#da532c"> | ||
| <meta name="msapplication-config" content="/assets/images/browserconfig.xml"> | ||
| <meta name="theme-color" content="#ffffff"> | ||
|
|
||
| <!-- Support light and dark mode, as it's not natively supported. See | ||
| https://github.com/just-the-docs/just-the-docs/issues/234. --> | ||
| <link rel="stylesheet" href="{{ '/assets/css/just-the-docs-eps-light.css' | relative_url }}" | ||
| media="(prefers-color-scheme: light)"> | ||
|
There was a problem hiding this comment. These spaces seem a bit weird 👀. Is that because of a formatter? There was a problem hiding this comment. Seems to have changed during cherry-pick from @oxkitsune's branch to mine. This formatting happens to me as part of IntelliJ formatting (CTRL-ALT-L). Currently no CI formatting/linting is in place for these files, nor could I find any so quickly to run it as a one-off. I'm happy with reverting if you'd like. If we go with IntelliJ formatting for now, I'll remove the space at the last line before There was a problem hiding this comment. Yeah let's do IntelliJ formatting for now :). |
||
| <link rel="stylesheet" href="{{ '/assets/css/just-the-docs-eps-dark.css' | relative_url }}" | ||
| media="(prefers-color-scheme: dark)"> | ||
|
|
||
| <meta name="google-site-verification" content="2GBzy2ufS8Rfqffu8T6iqng6dbDw9EKuykMisUZU3IQ"/> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,20 @@ | ||
| // Add support for external anchor icons. | ||
|
There was a problem hiding this comment. This "style" of writing sounds like an XXX to me. WDYT about changing it to: "Adds support for...". Not sure if that is the right way to go, but maybe it makes more sense 🤔. There was a problem hiding this comment. I think such comments are similar to in-code comments (Java example) which can carry the same mood. It is just a hard-to-explain feeling, but to me the style of 'Adds' is a bit awkward in this context and feels more fitting in JavaDoc-type of comments. 😅 But I'd be happy to change this, but then it should be applied in other places too. There was a problem hiding this comment. We could meet in the middle and use There was a problem hiding this comment. There is a difference in behavior between There was a problem hiding this comment. TIL! Agree that we can then leave it as-is. |
||
| .external > svg { | ||
| width: 1rem; | ||
| vertical-align: text-bottom; | ||
| } | ||
|
|
||
| .label { | ||
| // Reduce spacing between labels and align with surrounding elements. | ||
| margin-left: 0 !important; | ||
| } | ||
|
|
||
| footer { | ||
| text-align: center; | ||
|
|
||
| img#logo { | ||
| width: 2rem; | ||
| margin: 0 auto; | ||
| display: block; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| // Overrides for Just the Docs. See | ||
| // https://github.com/just-the-docs/just-the-docs/blob/main/_sass/support/_variables.scss. | ||
|
|
||
| // Grid system. | ||
| $nav-width: 400px; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| @import "./color_schemes/dark"; | ||
| @import "_variables"; | ||
| @import "_common"; | ||
|
|
||
| // Swap `$blue-000` and `$blue-300`, mainly for callouts. This is done by | ||
| // default for red, but not for other colors. | ||
| $blue-000: #183385; | ||
| $blue-300: #2c84fa; | ||
|
|
||
| // Use light-theme greys in dark theme to have summary callouts stand out more. | ||
| $grey-dk-000: $grey-lt-000; | ||
| $grey-dk-100: $grey-lt-100; | ||
| $grey-dk-200: $grey-lt-200; | ||
| $grey-dk-250: $grey-lt-200; | ||
| $grey-dk-300: $grey-lt-300; | ||
|
Comment on lines
+12
to
+16
There was a problem hiding this comment. Just checking: only 250 having an "off' mapping is intended? There was a problem hiding this comment. I think it is based on the colors defined by There was a problem hiding this comment. Wow 😄 (Maybe worth a comment; not sure.) There was a problem hiding this comment. Makes sense. Added a comment 👍. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: this will only be used in the next PR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. All changes in this PR won't be effective on
masteryet but are (almost all -- cases where we didn't, I tested locally against thewebsitebranch) already present on thewebsitebranch and therefore deployed. After @rickie's docgen modules, I'll open a PR to move the Ruby templating logic and a subsequent PR to change the GHA logic.