Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Christmas Cody in README and on website home page #404

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

jarmilakaiser
Copy link
Contributor

No description provided.

@rickie rickie added the documentation A documentation update label Dec 9, 2022
@rickie rickie added this to the 0.6.0 milestone Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie requested review from Stephan202 and rickie December 9, 2022 15:02
@rickie rickie force-pushed the jarmilakaiser/christmas-cody branch from d4823b5 to cdcb739 Compare December 9, 2022 15:02
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with @jarmilakaiser that in the Files changed tab the .svg looks really small but in the README it looks perfect 😍!

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like indeed! I think it makes sense to keep the tiny logo as-is.

Suggested commit message:

Show Christmas Cody in README and on website home page (#404)

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letssss go! Nice contribution @jarmilakaiser 😉.

@rickie rickie changed the title Replace Cody logo in README with a Christmas version Show Christmas Cody in README and on website home page Dec 9, 2022
@rickie rickie merged commit 0153c14 into master Dec 9, 2022
@rickie rickie deleted the jarmilakaiser/christmas-cody branch December 9, 2022 15:27
jarmilakaiser added a commit that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A documentation update
Development

Successfully merging this pull request may close these issues.

3 participants