Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop indentation in feature request issue template #403

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Drop indentation in feature request issue template #403

merged 1 commit into from
Dec 9, 2022

Conversation

rickie
Copy link
Member

@rickie rickie commented Dec 8, 2022 •
edited by Stephan202
Loading

(This has no priority but a minor quality of life improvement.)

When creating a ticket it is a bit annoying that the proposed format and code indented.
One should manually remove this which is not so nice and can be forgotten.
I also noticed others didn't always notice this indentation.

Let me know what you guys think :).

Suggested commit message:

Drop indentation in feature request issue template (#403)

While there, add "Improve performance" as a rewrite reason.

@rickie rickie added the documentation A documentation update label Dec 8, 2022
@rickie rickie requested review from Stephan202 and japborst December 8, 2022 19:27
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

japborst
japborst approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@japborst japborst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@Stephan202 Stephan202 added this to the 0.6.0 milestone Dec 9, 2022
Stephan202
Stephan202 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

Tweaked the suggested commit message 🙃

@rickie rickie changed the title Improve feature request template usability Drop indentation in feature request issue template Dec 9, 2022
@rickie rickie merged commit 3ee527f into master Dec 9, 2022
@rickie rickie deleted the rossendrijver/issue-template branch December 9, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japborst japborst japborst approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
documentation A documentation update
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rickie @Stephan202 @japborst