Assorted ZoneOffset improvements
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Had a bit of a struggle to come up with a good name for the PR... so ideas welcome 😄) |
|
Validated downstream, results are promising 😄. |
werli
approved these changes
Feb 15, 2022
EnricSala
approved these changes
Feb 15, 2022
Stephan202
force-pushed
the
rossendrijver/zoneoffset_improvements
branch
from
82943cf to
0bfa9e1
Compare
Stephan202
approved these changes
Apr 10, 2022
Comment on lines
148
to
149
| " ZoneOffset z1 = ZoneOffset.UTC;", | ||
| " ZoneOffset z2 = ZoneOffset.MIN;", |
There was a problem hiding this comment.
In this case we can use the identification test to verify that only one is flagged; the replacement logic is already sufficiently covered.
Comment on lines
+62
to
+73
| /** Prefer {@link Instant#atOffset(ZoneOffset)} over the more verbose alternative. */ | ||
| static final class InstantAtOffset { | ||
| @BeforeTemplate | ||
| OffsetDateTime before(Instant instant, ZoneOffset zoneOffset) { | ||
| return OffsetDateTime.ofInstant(instant, zoneOffset); | ||
| } | ||
|
|
||
| @AfterTemplate | ||
| OffsetDateTime after(Instant instant, ZoneOffset zoneOffset) { | ||
| return instant.atOffset(zoneOffset); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not for this PR, but something to ponder: ideally we generalize a rule such as this one, such that OffsetDateTime::ofInstant is also rewritten to Instant::atOffset. (Or not 🤔.)
|
Changes LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZoneOffset.UTCas candidate.Instant#atOffSetoverOffsetDateTime#ofInstant.