Upgrade org.springframework:spring-framework-bom 5.3.27 -> 6.0.8 - abandoned #356
Conversation
|
Suggested commit message: |
There was a problem hiding this comment.
The Spring 6 bytecode requires JDK 17. We should either:
- Just not upgrade yet, but TBD for how long.
- Avoid compiling and testing a subset of classes on JDK 11, though TBD how.
- Just raise the baseline to JDK 17; it's almost 2023, after all.
Option (2) is most work, but if we put in the work, we might use it to also solve the problem of supporting multiple incompatible versions of the same library and/or making it easier for users to (de)select rules and checks for a specific library. For example, perhaps there should be a Spring 6-focussed Maven module. (OTOH, supporting Spring 5 still without duplication might get messy then; need to think about it.)
Picnic-Bot
force-pushed
the
renovate/org.springframework-spring-framework-bom-6.x
branch
2 times, most recently
from
7084682 to
484fe31
Compare
Picnic-Bot
changed the title
|
Will add the label |
Summary of changes: - Use JDK 11.0.19 instead of 11.0.18. - Use JDK 17.0.7 instead of 17.0.6. - Use JDK 20.0.1 instead of 19.0.2. - Drop the early access build, as Error Prone is currently not compatible with JDK 21-ea. See: - https://www.oracle.com/java/technologies/javase/11-0-19-relnotes.html - https://www.oracle.com/java/technologies/javase/17-0-7-relnotes.html - https://www.oracle.com/java/technologies/javase/20-relnote-issues.html - https://www.oracle.com/java/technologies/javase/20-0-1-relnotes.html
Picnic-Bot
force-pushed
the
renovate/org.springframework-spring-framework-bom-6.x
branch
from
484fe31 to
1d57c8d
Compare
Picnic-Bot
changed the title
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
renovate/org.springframework-spring-framework-bom-6.x
branch
from
1d57c8d to
206cea6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # the code is compiled using JDK 17, while the tests are executed | ||
| # using JDK 11. | ||
| - name: Check out code | ||
| uses: actions/[email protected] |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
| with: | ||
| persist-credentials: false | ||
| - name: Set up JDK | ||
| uses: actions/[email protected] |
Check warning
Code scanning / Scorecard
Pinned-Dependencies
|
Kudos, SonarCloud Quality Gate passed!
|
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
| @DisabledForJreRange(max = JRE.JAVA_16 /* Spring targets JDK 17. */) | ||
| @MethodSource("validateRuleCollectionTestCases") | ||
| @ParameterizedTest | ||
| void validateRuleCollectionWithJdk17AndAbove(Class<?> clazz) { | ||
| if (JDK_17_PLUS_RULE_COLLECTIONS.contains(clazz)) { | ||
| RefasterRuleCollection.validate(clazz); | ||
| } | ||
| } |
There was a problem hiding this comment.
We can of course instead loop over JDK_17_PLUS_RULE_COLLECTIONS, but I wanted to stick with a single source of parameterized test elements. 🤷
An alternative approach would be to have a single parameterized test with (Class<?> clazz, JRE minJre) parameters, but that seems overkill for now. If/when we need to introduce JDK 21-only tests while still supporting JDK 11 we should reconsider.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
rickie
force-pushed
the
sschroevers/require-jdk-17
branch
from
c52841e to
0ccbf97
Compare
Stephan202
force-pushed
the
sschroevers/require-jdk-17
branch
from
0ccbf97 to
81f6d3f
Compare
Picnic-Bot
changed the title
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
|
This PR got replaced by #679. |
Stephan202
force-pushed
the
sschroevers/require-jdk-17
branch
from
81f6d3f to
5e8b4f4
Compare
|
I have replicated the changes in this PR to #679, so will drop this branch. |
Stephan202
deleted the
renovate/org.springframework-spring-framework-bom-6.x
branch
This PR contains the following updates:
5.3.27->6.0.8Release Notes
spring-projects/spring-framework
v6.0.8Compare Source
⭐ New Features
StringUtils.truncate()#30290ObjectUtils.nullSafeConciseToString()#30286Cookieattributes inCookieResultMatchersforMockMvc#30285SameSitecookie attribute inMockMvcHttpConnector#30264MockCookieto make use of Servlet 6.0 APIs and semantics for "attributes" #30263initRequestBuilderinDefaultWebClient#30254HttpMethodreflection hint toObjectToObjectConverterRuntimeHints#30201ConstructorReference#30189Collections.unmodifiableList(new ArrayList(..))withList.copyOf()#30166InputStream.readAllBytes()inFileCopyUtils.copyToByteArray()#30155🐞 Bug Fixes
default-destroy-methodin XML config #30301titleinequals()andhashCode()ofProblemDetail#30294@HttpExchangeinterface does not resolve return type correctly while using with suspending methods #30266AbstractMessageWriterResultHandler#30214SharedEntityManagerCreator#30161📔 Documentation
@PathVariablereference documentation code snippets #30243@EnableWebSocket#30183🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@1993heqiang, @TAKETODAY, @ZouHongxue, @alexjansons, @divcon, @edyda99, @filipblondeel, @ghostg00, @giuseppemilicia, @izeye, @justin-tay, @krzyk, @kyuarl21, @quaff, @shitian9, @simonbasle, @srivatsa-cfp, @ssang1105, @stsypanov, @wizard4wu, and @yuzawa-san
v6.0.7Compare Source
⭐ New Features
matchesoperator #30144matchesoperator #30140AbstractAutowireCapableBeanFactory#30103DefaultServerRequestBuildermethods #30046🐞 Bug Fixes
processAotfails when Bean Validation API present but no provider found #30130@Autowired/@Valuedoes not work on inner bean in native #29803TransactionalOperator#27572java.lang.Objecton a JDK proxy #25316📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@EnricSala, @MrCoffee77, @abelsromero, @edyda99, @liupeng12345, @srivatsa-cfp, and @yuzawa-san
v6.0.6Compare Source
⭐ New Features
readNBytesin ByteArrayHttpMessageConverter when contentLength is available #30010@Nullableannotations toLogMessage.formatmethods #30006CoroutinesUtils#invokeSuspendingFunctioncontract #30005@SubscribeMappingmethod not called when built as native image #30002ContextViewinstead ofContextinServerWebExchangeContextFilter#29691@Valuefor record injection #28774🐞 Bug Fixes
HttpServiceProxyFactoryExtensions.kttospring-webmodule #30042PathMatchingResourcePatternResolvercan no longer handle paths containing spaces and special characters #30031NullPointerExceptionif passing an anonymous class toReflectionsHint#registerType#29774@Repositoryclass #29764📔 Documentation
@AspectJargument name resolution algorithm is outdated in reference manual #30026chompandfoldsettings in reference documentation #30001🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@1004789224, @1993heqiang, @AlexElin, @diguage, @divcon, @izeye, @kilink, @lenoch7, @sergiuprdn, @singhbaljit, and @violetagg
v6.0.5Compare Source
⭐ New Features
CacheControl#29955HttpServiceProxyFactory#createClientKotlin extension #29942TransactionalOperator.executeAndAwaitnullability #29919SharedEntityManagerCreator'squeryTerminatingMethodsset #29886@NullabletoProblemDetail.setPropertyvalue argument #29868ConcurrentExecutorAdapterfor removal in 6.1 #29865Jackson2ObjectMapperBuilder#configureFeatureexception handling #29859http.client.requestsMetrics No Longer Haveclient.nameTag #29839@Aspectclasses to extend concrete@Aspectclasses #29830@JmsListenersubscription #29790@JsonDeserialize(builder = ...)does not work in GraalVM native image #29646@RequestMappingwithout patterns should match root path as both "" and "/" #29625@JsonNamingstrategy is not supported in GraalVM native image #29386DatabaseClientis eagerly invoked #29367CloseStatus.SESSION\_NOT\_RELIABLE#29220OptionalinPayloadMethodArgumentResolver#28945MockMvc.multipart()Kotlin extensions withHttpMethod#28634ModelAttributeMethodProcessorKotlin exception handling #23846🐞 Bug Fixes
ex.getPropertyName()is not initialized inResponseEntityExceptionHandler#handleTypeMismatch#29959MockHttpServletRequest#setContentTypefails withStringIndexOutOfBoundsException#29255InMemoryWebSessionStore#changeSessionIdmakes blocking calls to UUID.randomUUID #29212forwarding-header-strategy=nativeor cloud platform detected #28601CoroutineContextin reactive transaction #27308📔 Documentation
@DynamicPropertySourceexamples regarding changes in Testcontainers #29939ControllerMappingReflectiveProcessordocumentation #29938primitivesDefaultedForNullValueinBeanPropertyRowMapper#29923DataClassRowMappersupports Java records #29814@Beanmethod return type for equivalence with XML example #29338@Beanreturn type #29944🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Drezir, @FutureGadget, @OlgaMaciaszek, @ThomHurks, @a364176773, @bcc829, @derrick-pericipio, @divcon, @etylermoss, @fml2, @izeye, @j-min5u, @j3graham, @jprinet, @krzyk, @ks-yim, @making, @manthanb, @quaff, @r331, @sephiroth-j, @srivatsa-cfp, @vikeychen, @wplong11, @xavier-b, @yuezk, @yuzawa-san, and @zhmaeff
v6.0.4Compare Source
⭐ New Features
@Converton JPA entities #29771@RequestPartdto not configured for reflection in aot #29749@Configurationclasses with Kotlin in native-image are broken #29663ResultActions.andExpectAll()#27317🐞 Bug Fixes
📔 Documentation
ConfigurableEnvironment#29693🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Dunemaster, @IDJack, @diguage, @izeye, and @quim3ra
v6.0.3Compare Source
⭐ New Features
MockClientHttpRequestandMockClientHttpResponse#29670RequestMappingHandlerMapping#handleNoMatch#29634ApplicationContextin AOT mode if AOT processing failed #29579@ModelAttributeand@InitBinderannotations@Reflective#29572BindingReflectionHintsRegistrarto support properties on records #29571🐞 Bug Fixes
ConstructorReferencedoes not generate AST representation of arrays #29665@Named,@ManagedBean, and other Jakarta annotations #29641NoHandlerFoundExceptionmistakenly returns request headers fromErrorResponse#getHeaders#29626@HttpExchangedoesn't work if there are bothURIand@PathVariablemethod parameters #29624boolean#29598request-scoped bean with@Lazyfails in native image (due to missing detection of CGLIB lazy resolution proxies) #29584Stringliteral (and vice versa) #28356📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Aashay-Chapatwala, @CoderYellow, @ShenFeng312, @Spark61, @divcon, @izeye, @koo-taejin, @mdeinum, @mhalbritter, @quaff, and @singhbaljit
v6.0.2Compare Source
⭐ New Features
🐞 Bug Fixes
📔 Documentation
v6.0.1Compare Source
⭐ New Features
SourceHttpMessageConverteroptional #29535LocalVariableTableParameterNameDiscoverercompletely (avoiding its exposure in native images) #29531LogAdapterto allow build-time code removal #29506🐞 Bug Fixes
📔 Documentation
SQLExceptionSubclassTranslatorin the upgrade guide #29518🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@Encyclopedias, @andregasser, @davidcostanzo, @divcon, @jiangying000, @mdeinum, and @wilkinsona
v6.0.0Compare Source
See What's New in Spring Framework 6.x and Upgrading to Spring Framework 6.x for upgrade instructions and details of new features.
⭐ New Features
📔 Documentation
🔨 Dependency Upgrades
❤️ Contributors
Thank you to all the contributors who worked on this release:
@ophiuhus and @wilkinsona