Add Reproducible Builds badge to README #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Thanks! Looks very nice! 🎉
Made one suggestion around link naming :)
Suggested commit message:
Add Reproducible Builds badge to README (#333)
NB: I didn't forget about jvm-repo-rebuild/reproducible-central#93!
| @@ -226,3 +227,5 @@ guidelines][contributing]. | |||
| [refaster]: https://errorprone.info/docs/refaster | |||
| [refaster-rules-bigdecimal]: https://github.com/PicnicSupermarket/error-prone-support/blob/master/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/BigDecimalRules.java | |||
| [refaster-rules]: https://github.com/PicnicSupermarket/error-prone-support/blob/master/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ | |||
| [reproducible-builds-badge]: https://img.shields.io/badge/Reproducible_Builds-ok-success?labelColor=1e5b96 | |||
There was a problem hiding this comment.
How was the color selected? 😄
(I guess that eventually it'd be cool to have dynamic badges that go red if the latest release is no longer reproducible ✨.)
There was a problem hiding this comment.
color was chosen after Reproducible Builds logo
rickie
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Nice contribution @hboutemy! 🚀
Changes, @Stephan202's suggestion, and the suggested commit message LGTM!
Let's see whether this works on remote forks 👀
rickie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
congratulations, your latest releases were proven reproducible
Let's celebrate with this badge :)