Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertJ: add missing ImportPolicy to after template #32

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

rickie
Copy link
Member

@rickie rickie commented Jan 17, 2022

Found this while applying the AssertJTemplates to picnic-payments. In the diff Assertions.assertThat occurred. After adding the import policy, and re-running patch it was statically imported.

There are no tests for this template collection yet. However, it is validated on picnic-payments and it can be validated by looking at the rest of the templates in this class. It was the only after template that contained assertThat without having this import policy.

@rickie rickie requested a review from Stephan202 January 17, 2022 10:17
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested commit message:

Configure static import policy for `AssertThatSetContainsExactlyOneElement` Refaster template (#32)

@Stephan202 Stephan202 merged commit 793a70c into master Jan 24, 2022
@Stephan202 Stephan202 deleted the rossendrijver/missing_import_policy_assertj branch January 24, 2022 09:02
@Stephan202 Stephan202 added this to the 0.1.0 milestone Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants