Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't update project.build.outputTimestamp on mvn versions:set #310

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Don't update project.build.outputTimestamp on mvn versions:set #310

merged 1 commit into from
Oct 24, 2022

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Oct 24, 2022 •
edited by Badbond
Loading

Noticed while testing #309. Suggested commit message:

Don't update `project.build.outputTimestamp` on `mvn versions:set` (#310)

As we rely on the value of `git.commit.time` instead.

@Stephan202 Stephan202 added this to the 0.5.0 milestone Oct 24, 2022
@Stephan202 Stephan202 requested review from Badbond and rickie October 24, 2022 04:33
Badbond
Badbond approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@Badbond Badbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for fixing this 🙏

Slightly tweaked the suggested commit message to not include the property substitution details of ${}. Feel free to revert if you do prefer that.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Oct 24, 2022
@rickie rickie force-pushed the sschroevers/improve-versions-maven-plugin-config branch from 1d709ec to 78715d6 Compare October 24, 2022 11:16
@Stephan202 @rickie
Don't update project.build.outputTimestamp on mvn versions:set
011d916 
As we rely on the value of `${git.commit.time}` instead.
@rickie rickie force-pushed the sschroevers/improve-versions-maven-plugin-config branch from 78715d6 to 011d916 Compare October 24, 2022 11:24
@rickie rickie merged commit 671ee1e into master Oct 24, 2022
@rickie rickie deleted the sschroevers/improve-versions-maven-plugin-config branch October 24, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Badbond Badbond Badbond approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @Badbond @rickie