Introduce Reactor ContextEmpty Refaster rule
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werli
force-pushed
the
werli/reactor-context
branch
from
a5ddfa1 to
fa1c966
Compare
|
^ Rebased and (hopefully) fixed the build. 👌 |
|
Added a commit to fix the build. If the formatter is removing an import in the output file, we can add it to the |
Stephan202
approved these changes
Oct 21, 2022
| static final class ContextEmpty { | ||
| @BeforeTemplate | ||
| Context before() { | ||
| return Context.of(ImmutableMap.of()); |
There was a problem hiding this comment.
Users outside of Picnic might be more likely to use new HashMap<>(); let's add a case for that.
There was a problem hiding this comment.
(Better would be to introduce a Matcher for this, but that's something for a separate PR.)
rickie
approved these changes
Oct 23, 2022
rickie
changed the title
Context#empty Refaster ruleContextEmpty Refaster rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure usage of the intended API.
Suggested commit message: