Make the build JDK 18+ compatible #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll get back to this PR later on. I had checked out the branch however and the advertised |
werli
approved these changes
Oct 19, 2022
Stephan202
force-pushed
the
rossendrijver/jdk-18-compatible
branch
from
5676b49 to
810fe58
Compare
Stephan202
approved these changes
Oct 22, 2022
Comment on lines
64
to
65
| // For more details, see https://bugs.openjdk.org/browse/JDK-8274336. | ||
| @SuppressWarnings("serial") |
There was a problem hiding this comment.
Suggested change
| // For more details, see https://bugs.openjdk.org/browse/JDK-8274336. | |
| @SuppressWarnings("serial") | |
| @SuppressWarnings("serial" /* Concrete instance will be `Serializable`. */) |
| @@ -36,6 +36,9 @@ public final class AmbiguousJsonCreator extends BugChecker implements Annotation | |||
| private static final Matcher<AnnotationTree> IS_JSON_CREATOR_ANNOTATION = | |||
| isType("com.fasterxml.jackson.annotation.JsonCreator"); | |||
|
|
|||
| /** Instantiates the default {@link AmbiguousJsonCreator}. */ | |||
There was a problem hiding this comment.
"The default" hints at there being a non-default instance, while in fact there can be zero or more equivalent instances. How about:
Suggested change
| /** Instantiates the default {@link AmbiguousJsonCreator}. */ | |
| /** Instantiates a new {@link AmbiguousJsonCreator} instance. */ |
(The three existing cases should be named "a default", as a contrast with "a customized".)
There was a problem hiding this comment.
Aha, I see. I used the same sentence that we already used in a few places 😬.
Stephan202
force-pushed
the
rossendrijver/jdk-18-compatible
branch
from
810fe58 to
e69f82d
Compare
|
Should've marked it ready a bit sooner. Will merge once last part is 🟢 . |
rickie
force-pushed
the
rossendrijver/jdk-18-compatible
branch
from
e69f82d to
5ecf901
Compare
rickie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@werli reported that he got some errors when running Error Prone Support with JDK 18.0.2.
After some investigation I found these two JDK bug reports:
The first one flagged quite some violations. To resolve these violations, the default non-arg constructors are added with Javadoc. This solution is not ideal. However by looking at the docs of the javadoc command, and more specifically the options, I don't see a way to configure the check to go around this...
For me, this check flags a lot of missing Javadocs during development. Therefore, it'd be a good idea to not disable this check and use this PR to make the code compatible with JDK 18.