Build and test on additional platforms and against additional JDKs #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
changed the base branch from
master
to
rossendrijver/jdk-18-compatible
Stephan202
force-pushed
the
rossendrijver/jdk-18-compatible
branch
from
5676b49 to
810fe58
Compare
Stephan202
force-pushed
the
rossendrijver/jdk-18-compatible
branch
from
810fe58 to
e69f82d
Compare
Stephan202
force-pushed
the
rossendrijver/run_more_jdks
branch
from
9771f9c to
3f62b5f
Compare
Stephan202
force-pushed
the
rossendrijver/run_more_jdks
branch
from
ea50ded to
da31915
Compare
Stephan202
approved these changes
Oct 22, 2022
There was a problem hiding this comment.
Rebased and added a commit based on what we discussed offline (if I recall the outcome exactly, that is), plus some other tweaks. In summary:
- Only support the latest non-LTS release.
- Use the latest LTS for non-Linux builds.
- Use specific macOS/Windows versions, like we do for Ubuntu.
- Use Zulu only for the EA build (since Temurin doesn't provide one, IIUC).
Suggested commit message:
Build and test on additional platforms and against additional JDK versions (#301)
|
Thanks for applying the suggestions from our last discussion 😄! Will mark it as ready for review :). |
rickie
added
the
chore
rickie
force-pushed
the
rossendrijver/jdk-18-compatible
branch
from
e69f82d to
5ecf901
Compare
Badbond
approved these changes
Oct 25, 2022
|
Merged the base branch into this branch (rebasing would require resolving a bunch of conflicts). Will merge once built. |
|
The UI-based merge operation didn't yield the expected result 🤔. Will fix. |
rickie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.