Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSF-9432 Introduce JUnit Arguments Refaster Rule #3

Merged
merged 4 commits into from
Aug 14, 2020
Merged

PSF-9432 Introduce JUnit Arguments Refaster Rule #3

merged 4 commits into from
Aug 14, 2020

Conversation

werli
Copy link
Member

@werli werli commented Aug 2, 2020

JIRA PSF-9432 - Implement a refaster rule for Arguments#arguments

Subjective

Transform Arguments#of calls to statically imported Arguments#arguments calls.

PS: The information on testing of varargs parameters was taken from a Github PR from a familiar face (at least the Github icon). 😉

@werli werli requested a review from Stephan202 August 2, 2020 14:27
MLabusquiere
MLabusquiere approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@MLabusquiere MLabusquiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know refaster but LGTM!

Stephan202
Stephan202 reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for picking this up. Sorry for the nits, but at almost 500 templates and counting I have to be a bit strict to retain sanity :)

error-prone-contrib/pom.xml Show resolved Hide resolved
...-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/JUnitArgumentsTemplates.java Outdated Show resolved Hide resolved
.../src/test/resources/tech/picnic/errorprone/bugpatterns/JUnitArgumentsTemplatesTestInput.java Outdated Show resolved Hide resolved
@werli
Copy link
Member Author

werli commented Aug 13, 2020

Sorry for the nits, but at almost 500 templates and counting I have to be a bit strict to retain sanity :)

Please, no reason to apologize.
All of your suggestions are valid and ultimately aim to standardize all rules. To me, that's the goal.

Stephan202
Stephan202 approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a tiny commit for some extra consistency. Super nice!

Will merge tomorrow :)

@werli
Copy link
Member Author

werli commented Aug 14, 2020

Nice! Thanks for all the suggestions and final tweaks 🙂

@MLabusquiere
Copy link
Contributor

Re-approving :)

@Stephan202 Stephan202 merged commit d4d4676 into master Aug 14, 2020
@Stephan202 Stephan202 deleted the werli/PSF-9432 branch August 14, 2020 09:32
@Stephan202 Stephan202 added this to the 0.1.0 milestone Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MLabusquiere MLabusquiere MLabusquiere approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@werli @MLabusquiere @Stephan202