Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Slf4JLogStatementTest to Slf4jLogStatementTest #289

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

Badbond
Copy link
Member

@Badbond Badbond commented Oct 10, 2022

The test class name is inconsistent with the actual class name. Spotted while generating the documentation website. Decided to split it off given the unforeseeable future of the documentation generation branches. Thought to do it in scope of #288 as we were already renaming files there to make Refaster naming consistent, but this class is unrelated in that regard.

Suggested commit message:

Rename `Slf4JLogStatementTest` to `Slf4jLogStatementTest` (#289)

@Badbond Badbond requested review from Stephan202 and rickie October 10, 2022 19:30
@Stephan202 Stephan202 added this to the 0.4.0 milestone Oct 10, 2022
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx! (The build fails for unrelated reasons, so already approving.)

@rickie rickie force-pushed the pdsoels/rename-slf4j-test-class branch from bb46114 to dccb8f0 Compare October 11, 2022 12:52
@rickie rickie merged commit 5cec0dd into master Oct 11, 2022
@rickie rickie deleted the pdsoels/rename-slf4j-test-class branch October 11, 2022 12:57
@rickie rickie added chore A task not related to code (build, formatting, process, ...) improvement and removed improvement chore A task not related to code (build, formatting, process, ...) labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants