Fix LexicographicalAnnotationAttributeListing string sorting
#281
Conversation
| */ | ||
| return ImmutableList.copyOf(SourceCode.treeToString(node, state).split("=", -1)); | ||
| return ImmutableList.copyOf( | ||
| SourceCode.treeToString(node, state).replaceAll("^\"|\"$", "").split("=", -1)); |
There was a problem hiding this comment.
Not sure if the right fix tbh.
But after loads of testing, I finally got that the escaped quotes were considered in the sorting, which we actually don't want, and we want to sort what's inside the string.
Thus filtering out the leading and trailing quotes (if exists) from there.
There was a problem hiding this comment.
Thanks for tracking down the source of the odd sorting! It looks like we should use ASTHelpers#constValue here; I'll push a proposal :)
There was a problem hiding this comment.
Oh, didn't know about this one :D
Thanks @Stephan202 for pushing those extras!
| */ | ||
| return ImmutableList.copyOf(SourceCode.treeToString(node, state).split("=", -1)); | ||
| return ImmutableList.copyOf( | ||
| SourceCode.treeToString(node, state).replaceAll("^\"|\"$", "").split("=", -1)); |
There was a problem hiding this comment.
Thanks for tracking down the source of the odd sorting! It looks like we should use ASTHelpers#constValue here; I'll push a proposal :)
|
Had a shower thought; added one more commit. |
rickie
changed the title
LexicographicalAnnotationAttributeListing string sorting
Suggested commit message: