Unify local and GitHub Actions website generation flow #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japborst
added
the
chore
japborst
force-pushed
the
japborst/local-builds
branch
from
44acf55 to
16481cb
Compare
Stephan202
force-pushed
the
japborst/local-builds
branch
from
16481cb to
ba9d437
Compare
|
Rebased; PR now targets |
japborst
force-pushed
the
japborst/local-builds
branch
from
1face1a to
e3fbaa3
Compare
Stephan202
force-pushed
the
japborst/local-builds
branch
from
e3fbaa3 to
8c1bdd8
Compare
Stephan202
approved these changes
Oct 7, 2022
| gem "jekyll", "4.2.2" | ||
| gem "jekyll-sitemap", "1.4" | ||
| gem "just-the-docs", "0.4.0.rc2" | ||
| gem "webrick", "1.7" |
There was a problem hiding this comment.
For other reviewers: webrick is used by jekyll serve.
rickie
approved these changes
Oct 9, 2022
japborst
changed the title
Stephan202
reviewed
Oct 9, 2022
Comment on lines
+27
to
+32
| ###### Switch Ruby versions | ||
|
|
||
| The required Ruby version is set in `.ruby-version`. To switch, you can use | ||
| [rvm][rvm] to manage your Ruby version. | ||
|
|
||
| ###### Resolve Bundler issues |
There was a problem hiding this comment.
@japborst I changed the grammar of these headers on purpose: the topic is "switching Ruby versions" and "resolveing Bundler issues". This also matches the format used for the top-level README. Any particular reason this was reverted?
There was a problem hiding this comment.
Reverted to be in line with the rest.
There was a problem hiding this comment.
The other headers do not use the imperative mood either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up from #253 (comment):
A big downside of the standard GitHub actions set up, is that one can not locally run this. Additionally, setting versions in the
gemfilecan quickly go out of date or misaligned compared to the GHA configuration.Here, we're moving away from the default GH pages configuration and run the jekyll commands ourselves s.t. we can specify all versions in our own
gemfile.