Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tidy-maven-plugin 1.1.0 -> 1.2.0 #271

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Oct 2, 2022

This PR contains the following updates:

Package Type Update Change
org.codehaus.mojo:tidy-maven-plugin (source) build minor 1.1.0 -> 1.2.0

  • If you want to rebase/retry this PR, click this checkbox.

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Oct 2, 2022

Suggested commit message:

Upgrade tidy-maven-plugin 1.1.0 -> 1.2.0 (#271)

See:
- https://github.com/mojohaus/tidy-maven-plugin/releases/tag/tidy-maven-plugin-1.2.0
- https://github.com/mojohaus/tidy-maven-plugin/compare/tidy-maven-plugin-1.1.0...tidy-maven-plugin-1.2.0

@Stephan202 Stephan202 added this to the 0.4.0 milestone Oct 2, 2022
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin isn't enabled by default, yet. We should open a separate PR to run tidy:check unless -Dverification.skip or -Dverification.warn is specified. (Due to the limited configurabiliy we my need to introduce the avoid-errors profile deleted in 3f6558b.) This change should be applied to the internal Maven Parent.

@Picnic-Bot Picnic-Bot force-pushed the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch 6 times, most recently from ffdbbf2 to 6f854e3 Compare October 8, 2022 01:02
@Stephan202 Stephan202 force-pushed the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch from 6f854e3 to 894b3b5 Compare October 8, 2022 14:22
@Picnic-Bot Picnic-Bot force-pushed the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch from 894b3b5 to 46d1621 Compare October 10, 2022 01:01
@rickie
Copy link
Member

rickie commented Oct 10, 2022

Nice, would like to pick this up but that will probably be after the release @Stephan202.

@rickie rickie modified the milestones: 0.4.0, 0.5.0 Oct 10, 2022
@Stephan202
Copy link
Member

👍 Should be easier once we've reviewed @Badbond's related PR against the internal Maven parent.

@Picnic-Bot Picnic-Bot force-pushed the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch 5 times, most recently from 1175a43 to 996f5dc Compare October 18, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch 6 times, most recently from 801afaa to 03713f9 Compare October 27, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch from 03713f9 to 489c64b Compare October 27, 2022 14:20
@rickie
Copy link
Member

rickie commented Oct 27, 2022

We can merge once 🟢.

@rickie rickie changed the title Upgrade org.codehaus.mojo:tidy-maven-plugin 1.1.0 -> 1.2.0 Upgrade tidy-maven-plugin 1.1.0 -> 1.2.0 Oct 27, 2022
@rickie rickie merged commit 81227cd into master Oct 27, 2022
@rickie rickie deleted the renovate/org.codehaus.mojo-tidy-maven-plugin-1.x branch October 27, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants