Fix typos and grammar in pom.xml
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
added
the
chore
japborst
approved these changes
Sep 28, 2022
|
Suggested commit message: |
Stephan202
force-pushed
the
rossendrijver/pom_changes
branch
from
31a0a91 to
73229c4
Compare
Stephan202
approved these changes
Sep 29, 2022
pom.xml
Outdated
| @@ -111,7 +111,7 @@ | |||
| <!-- This argument *can* be set through Surefire's | |||
| 'systemPropertyVariables' configuration setting, but by placing it | |||
| here it automatically also applies to the Failsafe plugin. On Unix | |||
| systems we use a lower-quality source of randomness, so as to avoid | |||
| systems we use a lower-quality source of randomness, to avoid | |||
There was a problem hiding this comment.
IDEA seems to unconditionally suggest this change, and IMHO it really hurts readability. I'll swap the sentence around.
pom.xml
Outdated
| @@ -133,7 +133,7 @@ | |||
| <error-prone.patch-args /> | |||
| <error-prone.self-check-args /> | |||
| <!-- The Maven `groupId` under which Error Prone dependencies are | |||
| published. By default we use an official Error Prone release. This | |||
| published. By default, we use an official Error Prone release. This | |||
pom.xml
Outdated
| <!-- The `build-checks` and `error-prone` profiles enable a whole | ||
| bunch of additional compile checks. By default those warnings break | ||
| <!-- The `build-checks` and `error-prone` profiles enable a bunch | ||
| of additional compile checks. By default, those warnings break |
|
Changes LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't help myself. IntelliJ is complaining about these things and therefore we should fix it.
@Stephan202 I know you're not a fan of the comma's, but IntelliJ shows a red line under it, so IMO it's worth fixing. Other people will see the same and I think it can't hurt 😄.