-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply small README improvements #266
Conversation
README.md
Outdated
@@ -139,10 +139,11 @@ Two things are kicking in here: | |||
Be sure to check out all [bug checks][bug-checks] and [refaster | |||
templates][refaster-templates]. | |||
|
|||
## 👷 Building | |||
## 👷 Building Error Prone Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we like to repeat the project's name? If it's preferred, should we also update below? e.g. How Error Prone Support works
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in Slack:
.. to clearly indicate we're switching from showing the tool in action (section above) to talking about the project itself.
On my first read, it seemed like the Building section was still about the example that is explained just above. Instead, we switch to documentation about the project itself. Open to other suggestions to make this distinction clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already an H1 (along with a nice emoji), so that should conceptually separate it.
However, I do see your point.
Alternatives:
Developing Error Prone Support
, similar to https://github.com/google/error-proneBuilding locally
Running Error Prone Support locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ps. if changing, we need to update the anchor (line 23)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Developing Error Prone Support
, will update. Including anchor, good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
f7091bf
to
313ce8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx! Rebased and added a commit.
Suggested commit message:
Apply small README improvements (#266)
README.md
Outdated
Error Prone Support is a [Picnic][picnic-blog]-opinionated extension of Google's | ||
[Error Prone][error-prone-orig-repo]. It aims to improve code quality, focussing | ||
on maintainability, consistency and avoidance of common pitfalls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping, whitespace at end of lines 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR :).
No description provided.