Replace occurrences of which with that in defining clauses
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggested commit message: |
rickie
force-pushed
the
rossendrijver/change-which-to-that
branch
from
2a3b09e to
8cd172c
Compare
|
Changes LGTM, I think we can merge right? :) |
|
Yep; merged. (Did replace the backticks in the suggested commit message with quotes, since "which" and "that" isn't code.) |
rickie
changed the title
which in defining clauses with thatwhich with that in defining clauses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this link to see some additional info on when to use
whichand when to usethat. It's not that easy to be honest 😄.I think there are more occurrences that can be changed but updating the BugPatterns was my initial goal, so leaving it at this for now seems good to me.