-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up documentation website generation and deployment #253
Changes from 1 commit
a2c547c
1d73f70
0d95718
964ec64
45f7703
087f520
378bfff
7d384f1
1033164
c9eae04
e800d23
2521fe5
f62b632
8b1f2ab
4ba8dd2
471bb6f
9890367
a0619f6
e2adb4a
d295e60
aa045b5
67e2f07
ed33906
baee39a
db0dc5d
1b5220a
ade5782
5a0c65e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ permissions: | |
pages: write | ||
id-token: write | ||
concurrency: | ||
group: "pages" | ||
group: pages | ||
cancel-in-progress: true | ||
jobs: | ||
build: | ||
|
@@ -19,13 +19,13 @@ jobs: | |
- name: Configure Github Pages | ||
uses: actions/[email protected] | ||
- name: Generate documentation | ||
run: bash ./generate-docs.sh | ||
run: ./generate-docs.sh | ||
- name: Build website with Jekyll | ||
uses: actions/[email protected] | ||
with: | ||
source: website/ | ||
destination: ./_site | ||
- name: Validating HTML output | ||
- name: Validate HTML output | ||
uses: anishathalye/[email protected] | ||
with: | ||
directory: ./_site | ||
|
@@ -34,11 +34,11 @@ jobs: | |
uses: actions/[email protected] | ||
deploy: | ||
if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch) | ||
needs: build | ||
runs-on: ubuntu-22.04 | ||
environment: | ||
name: github-pages | ||
url: ${{ steps.deployment.outputs.page_url }} | ||
runs-on: ubuntu-22.04 | ||
needs: build | ||
steps: | ||
- name: Deploy to GitHub Pages | ||
id: deployment | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
#!/usr/bin/env bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll push some suggestions for this file. (Not relying on the side-effect of |
||
|
||
set -e -u -o pipefail | ||
|
||
WEBSITE_FOLDER="website" | ||
HOMEPAGE="${WEBSITE_FOLDER}/index.md" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,12 @@ | ||
### Jekyll ### | ||
_site/ | ||
.sass-cache/ | ||
# Generated by Bundler and Jekyll. | ||
.bundle/ | ||
Gemfile.lock | ||
.jekyll-cache/ | ||
.jekyll-metadata | ||
Gemfile.lock | ||
|
||
# Ignore folders generated by Bundler | ||
.bundle/ | ||
.sass-cache/ | ||
_site/ | ||
vendor/ | ||
|
||
# Generated content | ||
# Generated by `../generate-docs.sh`. | ||
*.bak | ||
index.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
source "https://rubygems.org" | ||
gem "github-pages", "~> 227" | ||
gem "rake", "~> 13.0" # Required for "just-the-docs" theme. | ||
gem "jekyll-sitemap", "~> 1.4" | ||
gem "html-proofer", "~> 4.4" | ||
gem "github-pages", "227" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we also fix the Ruby version used? See https://bundler.io/guides/gemfile_ruby.html#specifying-a-ruby-version. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would like to make part of the larger initiative, see #253 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I didn't read all of the comments so was just a drive-by comment. SGTM 👍 |
||
gem "html-proofer", "4.4.1" | ||
gem "just-the-docs", "0.4.0.rc2" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,39 +3,36 @@ title: Error Prone Support | |
logo: assets/images/favicon.svg | ||
url: https://error-prone.picnic.tech | ||
description: >- | ||
japborst marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Error Prone extensions: extra bug checkers and a large battery of Refaster templates. | ||
Error Prone extensions: extra bug checkers and a large battery of Refaster | ||
templates. | ||
|
||
remote_theme: just-the-docs/just-the-docs | ||
theme: just-the-docs | ||
plugins: | ||
- jekyll-remote-theme | ||
- jekyll-sitemap | ||
- jekyll-sitemap | ||
|
||
# Do not deploy these files and folders through GitHub pages. | ||
# Files and directories not to be deployed through GitHub pages. | ||
exclude: | ||
- Gemfile | ||
- Gemfile.lock | ||
- README.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting... I did not have that issue 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have this issue either. And I also don't see the |
||
- vendor | ||
|
||
permalink: pretty # Use /doc/ instead of /doc.html. | ||
|
||
# Theme configuration. | ||
search_enabled: true | ||
heading_anchors: true | ||
# See https://jekyllrb.com/docs/permalinks/#built-in-formats. | ||
permalink: pretty | ||
|
||
# See https://just-the-docs.github.io/just-the-docs/docs/navigation-structure/#external-navigation-links. | ||
nav_external_links: | ||
- title: Error Prone Support on GitHub | ||
url: https://github.com/PicnicSupermarket/error-prone-support | ||
hide_icon: false | ||
|
||
# Author configuration. | ||
twitter: | ||
username: picnic | ||
card: summary | ||
|
||
# See https://jekyll.github.io/jekyll-seo-tag/usage/. | ||
social: | ||
name: Picnic | ||
links: | ||
- https://github.com/PicnicSupermarket | ||
- https://twitter.com/picnic | ||
- https://www.linkedin.com/company/picnictechnologies | ||
twitter: | ||
username: picnic | ||
card: summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be clearer to have a newline between these two parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation already takes care of that. We also don't do that above, or in
build.yaml
.