Fix typos and grammar in error-prone-contrib/README.md
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
approved these changes
Sep 20, 2022
error-prone-contrib/README.md
Outdated
| replacement would cause a compilation error.) | ||
| - Extend the `@Repeated` match semantics such that it also covers non-varargs | ||
| methods. For a motivating example see google/error-prone#568. | ||
| - When matching explicit type references, also match super types. For a | ||
| motivating example, see the two subtly difference loop definitions in | ||
| motivating example, see the two subtly different loop definitions in | ||
| `CollectionRemoveAllFromCollectionBlock`. |
error-prone-contrib/README.md
Outdated
| such as this could form the basis for many other features listed here. (As a | ||
| - More generally, investigate ways to plug in fully dynamic behavior, e.g. | ||
| by providing hooks which enable plugging in arbitrary predicates/transformations. | ||
| The result would be a Refaster/`BugChecker` hybrid. A feature such as this |
There was a problem hiding this comment.
Suggested change
| The result would be a Refaster/`BugChecker` hybrid. A feature such as this | |
| The result would be a Refaster/`BugChecker` hybrid. A feature like this |
error-prone-contrib/README.md
Outdated
| - More generally, investigate ways to plug in fully dynamic behavior, e.g. | ||
| by providing hooks which enable plugging in arbitrary predicates/transformations. | ||
| The result would be a Refaster/`BugChecker` hybrid. A feature such as this | ||
| could form the basis for many other features listed here. (As a | ||
| concrete example, consider the ability to reference | ||
| `com.google.errorprone.matchers.Matcher` implementations.) | ||
| - Provide a way to match lambda expressions and method references which match a |
There was a problem hiding this comment.
We recently introduced this in 62fe10f, so removing this line.
Stephan202
force-pushed
the
svavahb/fix_contrib_readme_typos
branch
from
3b28086 to
22002ac
Compare
Stephan202
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Tnx for the fixes!
Rebased and added a small commit. Ideally we get rid of this file before open-sourcing, so let's not spend to much on this. (At the same time we should find another low-key way of collecting ideas; details TBD.)
Suggested commit message:
Fix typos and grammar in `error-prone-contrib/README.md` (#250)
While there, drop an obsolete TODO entry.
rickie
changed the title
error-prone-contrib/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted two typos, and then decided to read through the whole thing to see if I could spot more. Turns out I could!