Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary BugCheckerRefactoringTestHelper file path prefixes #248

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

rickie
Copy link
Member

@rickie rickie commented Sep 20, 2022

There are a few occurrences where such a setup is required, we mostly use pkg/ for that, left those instances as-is.

Using prefixes and packages is only used in a few occasions. Usually this is not required and EP already sees what is the in and output, no need to add an in/ or out/ to the file paths, it adds nothing.

@rickie rickie added this to the 0.4.0 milestone Sep 20, 2022
@rickie rickie requested a review from Stephan202 September 20, 2022 07:43
@rickie rickie requested a review from Badbond September 20, 2022 17:56
@rickie rickie changed the title Drop obsolete package prefix in BugChecker tests Drop obsolete path prefix in BugChecker tests Sep 20, 2022
@Stephan202 Stephan202 force-pushed the rossendrijver/simplify_tests branch from 3d3163b to 7ae5ea4 Compare September 20, 2022 20:34
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a commit. Suggested commit message:

Drop unnecessary `BugCheckerRefactoringTestHelper` file path prefixes (#248)

@rickie rickie removed the request for review from Badbond September 27, 2022 11:52
@rickie rickie changed the title Drop obsolete path prefix in BugChecker tests Drop unnecessary BugCheckerRefactoringTestHelper file path prefixes Sep 27, 2022
@rickie rickie merged commit e37da2a into master Sep 27, 2022
@rickie rickie deleted the rossendrijver/simplify_tests branch September 27, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants