ImmutableSetMultiMapTemplates: Don't modify the identifier of the lambda
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
approved these changes
Jan 1, 2022
|
I have a question because I'm curious 😄 . The change in this PR is rather specific. While on the other hand, the suggested commit message is a little more high-level compared to the specific change. What is the reason to (e.g.) not mention the template in the message? |
|
I assumed (but should have asked) that this change resolves it for all such templates. For me the fact that only one template was impacted is immaterial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the identifier in the after template is different then in the before template, the identifier is updated. This is a side-effect which we generally do not want. Perhaps we should create a check for this in the future 😉