Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce release.yml to improve GitHub release notes generation #213

Merged
merged 3 commits into from
Aug 24, 2022
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
changelog:
exclude:
labels:
- ignore-changelog
categories:
- title: ":rocket: New Error Prone checks"
labels:
- "error prone check"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this indicate the "new" aspect? Otherwise one could also apply the label to improvement PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this with @ibabiankou offline, will propose something new. We think we should make a split between Error Prone checks and Refaster templates.

- title: ":sunny: New Refaster templates"
labels:
- "refaster template"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question 🙃

- title: ":sparkles: New features and improvements"
labels:
- "new feature"
- improvement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we quote all strings for consistency.

- title: ":warning: Update considerations and deprecations"
labels:
- "breaking change"
- deprecation
- title: ":bug: Bug fixes"
labels:
- bug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would suit issues, but not PRs. Maybe add "bug fix" 🤔

- title: ":books: Documentation, tests and build"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- title: ":books: Documentation, tests and build"
- title: ":books: Documentation, test and build improvements"

labels:
- documentation
- chores
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- chores
- chore

?

- title: ":chart_with_upwards_trend: Dependency upgrades"
labels:
- dependencies
- title: "Other changes"
labels:
- "*"