StaticImportCheck: Add extra test cases #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werli
approved these changes
Nov 10, 2021
error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/StaticImportCheckTest.java
Show resolved
Hide resolved
Stephan202
force-pushed
the
rossendrijver/static_import_extra_tests
branch
from
b2fcc69 to
13e28c8
Compare
Stephan202
approved these changes
Nov 14, 2021
There was a problem hiding this comment.
Rebased and resolved conflicts.
Will swap the statements merge, but the idea is not to add a test case for all constants 😅 (not that I'm opposed, but if we really want to do that quite a few more are missing.)
Suggested commit message:
Extend `StaticImportCheck` test coverage (#21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying some things and added a few tests after our discussion @werli .