Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nohttp-checkstyle #206

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Enable nohttp-checkstyle #206

merged 1 commit into from
Aug 22, 2022

Conversation

Stephan202
Copy link
Member

Suggested commit message:

Enable `nohttp-checkstyle` (#206)

While this Checkstyle configuration only flags `http://` usages in
Maven-managed source files (thus not in e.g. `pom.xml` or `README.md`
files), this is a low-effort improvement.

While this Checkstyle configuration only flags `http://` usages in
Maven-managed source files (thus not in e.g. `pom.xml` or `README.md`
files), this is a low-effort improvement.
@Stephan202 Stephan202 requested a review from rickie August 19, 2022 20:14
@Stephan202
Copy link
Member Author

Also filed spring-io/nohttp#56.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting check, let's do it.

  1. Should we also adopt this internally?
  2. In the commit message we often mention check (when we turn on a Checkstyle check or module), but in this case it is already quite clear, so also fine with the current proposal.

@Stephan202
Copy link
Member Author

W.r.t. (1): would be good to do so. First step would be to assess impact (how much to clean up, how many edge cases).

W.r.t. (2): Fair! I went with the current proposal because we're also pulling in a whole new dependency 🤷

@Stephan202 Stephan202 added this to the 0.1.1 milestone Aug 22, 2022
@Stephan202 Stephan202 merged commit 50aaf77 into master Aug 22, 2022
@Stephan202 Stephan202 deleted the sschroevers/introduce-nohttp branch August 22, 2022 07:39
@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants