Require static import of com.google.errorprone.matchers.Matchers methods
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
reviewed
Aug 17, 2022
Comment on lines
63
to
65
| " // BUG: Diagnostic contains:", | ||
| " private static final Matcher<AnnotationTree> FOO = Matchers.isType(\"org.junit.jupiter.api.Test\");", | ||
| "", |
There was a problem hiding this comment.
I propose that we just add Matchers.isType(\"org.junit.jupiter.api.Test\") to the method m() below. (The usage doesn't need to be "realistic"; see e.g. the collector definitions.)
There was a problem hiding this comment.
In fact: right now most entries aren't tested, so propose that we just drop this. (If/when we have a Pitest mutator that mutates varargs entries we should reconsider there.)
|
Suggested commit message: |
Stephan202
force-pushed
the
gdejong/PSM-1563
branch
from
40ec911 to
1534572
Compare
Stephan202
approved these changes
Aug 18, 2022
Comment on lines
63
to
65
| " // BUG: Diagnostic contains:", | ||
| " private static final Matcher<AnnotationTree> FOO = Matchers.isType(\"org.junit.jupiter.api.Test\");", | ||
| "", |
There was a problem hiding this comment.
In fact: right now most entries aren't tested, so propose that we just drop this. (If/when we have a Pitest mutator that mutates varargs entries we should reconsider there.)
rickie
approved these changes
Aug 18, 2022
rickie
changed the title
StaticImport: Add com.google.errorprone.matchers.Matchers candidates com.google.errorprone.matchers.Matchers methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
com.google.errorprone.matchers.Matchersto theStaticImportcheck, as methods from this class should always be statically imported.Example:
Suggested commit message: