Add Refaster rule for Flux#concat for a single Mono or Flux
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
approved these changes
Nov 10, 2021
| @@ -161,6 +161,32 @@ private ReactorTemplates() {} | |||
| } | |||
| } | |||
|
|
|||
| /** Don't use {@link Flux#concat(Publisher)} with only a single {@link Mono}. */ | |||
| abstract static class FluxConcatOfOneMono<T> { | |||
There was a problem hiding this comment.
We can use static final here instead of abstract. abstract for templates is only when we need to use the Refaster @Placeholder.
There was a problem hiding this comment.
Additionally, the convention for naming the templates is almost exactly describing the beforetemplate content. So it seems that we can even drop OfOne.
I'll push something :)
There was a problem hiding this comment.
I don't know why I described it precisely the other way around here.. My bad 😅
Stephan202
reviewed
Nov 13, 2021
...r-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ReactorTemplates.java
Outdated
Show resolved
Hide resolved
...contrib/src/test/resources/tech/picnic/errorprone/bugpatterns/ReactorTemplatesTestInput.java
Outdated
Show resolved
Hide resolved
Stephan202
approved these changes
Nov 13, 2021
Comment on lines
+177
to
+188
| /** Don't unnecessarily invoke {@link Flux#concat(Publisher)}. */ | ||
| static final class FluxIdentity<T> { | ||
| @BeforeTemplate | ||
| Flux<T> before(Flux<T> flux) { | ||
| return Flux.concat(flux); | ||
| } | ||
|
|
||
| @AfterTemplate | ||
| Flux<T> after(Flux<T> flux) { | ||
| return flux; | ||
| } | ||
| } |
There was a problem hiding this comment.
@rickie This template could be folded into the "vacuous conversion" bug checker we discussed a while back.
There was a problem hiding this comment.
Nice! Will add it to the list @Stephan202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thx to @rickie for contributing 👍