Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer String#valueOf over Objects#toString #192

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Prefer String#valueOf over Objects#toString #192

merged 1 commit into from
Aug 22, 2022

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Aug 13, 2022 •
edited
Loading

Suggested commit message:

Prefer `String#valueOf` over `Objects#toString` (#192)

While there, drop obsolete `NoFunctionalReturnType` warning suppressions.

Internally we use String#valueOf way more frequently than Objects#toString, so let's settle on it.

@Stephan202
Prefer String#valueOf over Objects#toString
bd58ad9 
While there, drop obsolete `NoFunctionalReturnType` warning suppressions.
@Stephan202 Stephan202 requested a review from rickie August 13, 2022 14:35
@Stephan202 Stephan202 added this to the 0.1.1 milestone Aug 13, 2022
@rickie rickie requested a review from EnricSala August 20, 2022 08:37
rickie
rickie approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@rickie rickie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Suggested commit message LGTM! 👍🏻

EDIT: (Enric is on holiday 😬)

@rickie rickie removed the request for review from EnricSala August 20, 2022 08:44
@rickie rickie merged commit 5657a48 into master Aug 22, 2022
@rickie rickie deleted the sschroevers/prefer-string-valueof branch August 22, 2022 08:29
@rickie rickie mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@werli werli werli approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @werli @rickie