StaticImport: Add WebEnvironment enum #19
Conversation
pom.xml
Outdated
| @@ -990,6 +995,7 @@ | |||
| <licenseMerge> | |||
| <!-- --> | |||
| BSD-3-Clause | |||
| | BSD License 3 | |||
There was a problem hiding this comment.
Ah I see that with respect to the sorting, the entry that is added should go two lines down. Will fix that when I apply the feedback :)
There was a problem hiding this comment.
The build also passes without this 👀
| @@ -113,13 +122,17 @@ void replacement() { | |||
| " @DateTimeFormat(iso = ISO.DATE) String date,", | |||
| " @DateTimeFormat(iso = ISO.DATE_TIME) String dateTime,", | |||
| " @DateTimeFormat(iso = ISO.TIME) String time) {}", | |||
| "", | |||
| " @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)", | |||
There was a problem hiding this comment.
Should we also add a test case for SpringBootTest.WebEnvironment.RANDOM_PORT?
pom.xml
Outdated
| @@ -281,7 +281,7 @@ | |||
| <dependency> | |||
| <groupId>io.projectreactor</groupId> | |||
| <artifactId>reactor-bom</artifactId> | |||
| <version>2020.0.11</version> | |||
| <version>2020.0.12</version> | |||
There was a problem hiding this comment.
Will you create a separate commit/PR to upgrade dependencies?
There was a problem hiding this comment.
Indeed, this is out of scope. I do happen to have prepared a set of upgrades already, so will push those and then rebase this PR.
Assorted upgrades and add license `BSD License 3`
Stephan202
force-pushed
the
rossendrijver/static_import_random_port
branch
from
370928a to
3845422
Compare
pom.xml
Outdated
| @@ -281,7 +281,7 @@ | |||
| <dependency> | |||
| <groupId>io.projectreactor</groupId> | |||
| <artifactId>reactor-bom</artifactId> | |||
| <version>2020.0.11</version> | |||
| <version>2020.0.12</version> | |||
There was a problem hiding this comment.
Indeed, this is out of scope. I do happen to have prepared a set of upgrades already, so will push those and then rebase this PR.
pom.xml
Outdated
| @@ -990,6 +995,7 @@ | |||
| <licenseMerge> | |||
| <!-- --> | |||
| BSD-3-Clause | |||
| | BSD License 3 | |||
There was a problem hiding this comment.
The build also passes without this 👀
Assorted upgrades and add license
BSD License 3