Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt @RequestAttribute from RequestMappingAnnotation check #189

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Exempt @RequestAttribute from RequestMappingAnnotation check #189

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
823618b
PSM-1555 Exempt @RequestAttribute from RequestMappingAnnotation check
ddeya Aug 11, 2022
9802de9
PSM-1555 Sort imports
ddeya Aug 11, 2022
35cf91c
Suggestions
rickie Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ne-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/RequestMappingAnnotation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ public final class RequestMappingAnnotation extends BugChecker implements Method
isType(ANN_PACKAGE_PREFIX + "PathVariable"),
isType(ANN_PACKAGE_PREFIX + "RequestBody"),
isType(ANN_PACKAGE_PREFIX + "RequestHeader"),
isType(ANN_PACKAGE_PREFIX + "RequestParam"))),
isType(ANN_PACKAGE_PREFIX + "RequestParam"),
isType(ANN_PACKAGE_PREFIX + "RequestAttribute"))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Let's keep the list sorted :)

Suggested change
isType(ANN_PACKAGE_PREFIX + "RequestParam"),
isType(ANN_PACKAGE_PREFIX + "RequestAttribute"))),
isType(ANN_PACKAGE_PREFIX + "RequestAttribute"),
isType(ANN_PACKAGE_PREFIX + "RequestParam"))),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Moving this up to retain sorting :).

isSameType("java.io.InputStream"),
isSameType("java.time.ZoneId"),
isSameType("java.util.Locale"),
Expand Down
4 changes: 4 additions & 0 deletions ...ontrib/src/test/java/tech/picnic/errorprone/bugpatterns/RequestMappingAnnotationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ void identification() {
"import org.springframework.web.bind.annotation.PathVariable;",
"import org.springframework.web.bind.annotation.PostMapping;",
"import org.springframework.web.bind.annotation.PutMapping;",
"import org.springframework.web.bind.annotation.RequestAttribute;",
"import org.springframework.web.bind.annotation.RequestBody;",
"import org.springframework.web.bind.annotation.RequestHeader;",
"import org.springframework.web.bind.annotation.RequestMapping;",
Expand Down Expand Up @@ -56,6 +57,9 @@ void identification() {
" A properRequestParam(@RequestParam String param);",
"",
" @RequestMapping",
" A properRequestAttribute(@RequestAttribute String param);",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then similarly here (also tweaked the parameter name):

Suggested change
" A properRequestParam(@RequestParam String param);",
"",
" @RequestMapping",
" A properRequestAttribute(@RequestAttribute String param);",
" A properRequestAttribute(@RequestAttribute String attribute);",
"",
" @RequestMapping",
" A properRequestParam(@RequestParam String param);",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" A properRequestAttribute(@RequestAttribute String param);",
" A properRequestAttribute(@RequestAttribute String attribute);",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also moving up to retain sorting 😄)

"",
" @RequestMapping",
" A properInputStream(InputStream input);",
"",
" @RequestMapping",
Expand Down